Changes semantics of TabSelectedAt. For multi-selection the TabStrip

chrome/browser/tabs/tab_strip_model.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/tabs/tab_strip_model.h"
 
 #include <algorithm>
 #include <map>
 
 #include "base/command_line.h"
@@ skipping 165 matching lines @@
   contents_data_[index]->contents = new_contents;
 
   FOR_EACH_OBSERVER(TabStripModelObserver, observers_,
                     TabReplacedAt(this, old_contents, new_contents, index));
 
   // When the selected tab contents is replaced send out selected notification
   // too. We do this as nearly all observers need to treat a replace of the
   // selected contents as selection changing.
   if (selected_index_ == index) {
     FOR_EACH_OBSERVER(TabStripModelObserver, observers_,
-                      TabSelectedAt(old_contents, new_contents,
-                                    selected_index_, false));
+                      TabSelectionChanged(this, old_contents, false));
   }
   return old_contents;
 }
 
 void TabStripModel::ReplaceNavigationControllerAt(
     int index, TabContentsWrapper* contents) {
   // This appears to be OK with no flicker since no redraw event
   // occurs between the call to add an aditional tab and one to close
   // the previous tab.
   InsertTabContentsAt(
@@ skipping 758 matching lines @@
   if (old_contents == new_contents)
     return;
 
   TabContentsWrapper* last_selected_contents = old_contents;
   if (last_selected_contents) {
     FOR_EACH_OBSERVER(TabStripModelObserver, observers_,
                       TabDeselected(last_selected_contents));
   }
 
   selected_index_ = to_index;
-  ObserverListBase<TabStripModelObserver>::Iterator it(observers_);
-  TabStripModelObserver* obs;
-  while ((obs = it.GetNext()) != NULL)
-    obs->TabSelectedAt(last_selected_contents, new_contents,
-                       selected_index_, user_gesture);
-  /*
-  FOR_EACH_OBSERVER(TabStripModelObserver, observers_,
-      TabSelectedAt(last_selected_contents, new_contents, selected_index_,
-                    user_gesture));
-                    */
+
+  FOR_EACH_OBSERVER(
+      TabStripModelObserver, observers_,
+      TabSelectionChanged(this, last_selected_contents, user_gesture));
 }
 
 void TabStripModel::SelectRelativeTab(bool next) {
   // This may happen during automated testing or if a user somehow buffers
   // many key accelerators.
   if (contents_data_.empty())
     return;
 
   int index = selected_index_;
   int delta = next ? 1 : -1;
@@ skipping 30 matching lines @@
 void TabStripModel::ForgetOpenersAndGroupsReferencing(
     const NavigationController* tab) {
   for (TabContentsDataVector::const_iterator i = contents_data_.begin();
        i != contents_data_.end(); ++i) {
     if ((*i)->group == tab)
       (*i)->group = NULL;
     if ((*i)->opener == tab)
       (*i)->opener = NULL;
   }
 }