Set cwd to the root of the git checkout when running git svn info.

Set cwd to the root of the git checkout when running git svn info.

URL value is dependent on the local directory. The current directory would
affect Base URL on Rietveld otherwise.

Do not use Repository Root instead of URL since git svn clone foo -T bar
wouldn't be correctly based.

Update RunCommand() to be able to pass cwd argument.

TEST=git cl upload is broken if I break this code.
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76791

[M-A Ruel, 2011-03-02 02:07:09]

I uploaded this change from within depot_tools/git_cl/ but base url was set
correctly. As a counter example I uploaded an (old and unrelated) change from
within depot_tools/git_cl without this patch and you can see that the base url
is wrong: http://codereview.chromium.org/6598087

[Mark Seaborn, 2011-03-02 02:20:28]

Looks good to me -- thanks for fixing this!  I assume this is not covered by an
automated test, BTW?

Mark

[M-A Ruel, 2011-03-02 02:26:14]

On 2011/03/02 02:20:28, Mark Seaborn wrote:
> Looks good to me -- thanks for fixing this!  I assume this is not covered by
an
> automated test, BTW?

No, my goal is to redo the test framework to reuse the framework using by
gclient smoke tests in the next quarter.

[M-A Ruel, 2011-03-03 18:50:22]

On 2011/03/02 02:26:14, Marc-Antoine Ruel wrote:
> On 2011/03/02 02:20:28, Mark Seaborn wrote:
> > Looks good to me -- thanks for fixing this!  I assume this is not covered by
> an
> > automated test, BTW?
> 
> No, my goal is to redo the test framework to reuse the framework using by
> gclient smoke tests in the next quarter.

Evan?

[Evan Martin, 2011-03-03 19:08:27]

Can you elaborate on what this means:
"Do not use Repository Root instead of URL since git svn clone foo -T bar 
wouldn't be correctly based. "

I am naive, but it seems we really do want repository root here... ?

[M-A Ruel, 2011-03-03 19:11:15]

On 2011/03/03 19:08:27, Evan Martin wrote:
> Can you elaborate on what this means:
> "Do not use Repository Root instead of URL since git svn clone foo -T bar 
> wouldn't be correctly based. "
> 
> I am naive, but it seems we really do want repository root here... ?

~/src/depot_tools> git svn info
Path: .
URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Repository Root: svn://svn.chromium.org/chrome
(...)

'Repository Root' depends on what you cloned, and my not represent the checkout
faithfully.

[Evan Martin, 2011-03-03 19:13:02]

Got it, thanks.  LGTM

[Evan Martin, 2011-03-03 19:50:34]

http://codereview.chromium.org/6591093/diff/1/git_cl/git_cl.py
File git_cl/git_cl.py (right):

http://codereview.chromium.org/6591093/diff/1/git_cl/git_cl.py#newcode816
git_cl/git_cl.py:816: remote_url = keys.get('URL', None)
FYI, I just learned that "git svn info --url" does this more simply.  (You
shouldn't do this as part of this change, just thought you'd like to know.)