Issue 6591075: Allow eval to be overridden with a callable non-function object.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6591075: Allow eval to be overridden with a callable non-function object. (Closed)

Created:
9 years, 9 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Allow eval to be overridden with a callable non-function object. We simply need to remove early checks in the resolve eval runtime functions. CallFunctionStub that follows will handle non-functions in the right way. Committed: http://code.google.com/p/v8/source/detail?r=7005

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -8 lines)			Patch
	M	src/runtime.cc	View		2 chunks	+2 lines, -8 lines	0 comments	Download
	A	test/mjsunit/override-eval-with-non-function.js	View		1 chunk	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM, nice and simple. :)

Expand Messages | Collapse Messages