Add check_for_file and check_for_tool functions to common.sh

common.sh

 # Copyright (c) 2010 The Chromium OS Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Common constants for build scripts
 # This must evaluate properly for both /bin/bash and /bin/sh
 
 # All scripts should die on error unless commands are specifically excepted
 # by prefixing with '!' or surrounded by 'set +e' / 'set -e'.
 # TODO: Re-enable this once shflags is less prone to dying.
@@ skipping 629 matching lines @@
     args="${args} --force_copy"
   fi
 
   # Modify the image for test, creating a new test image
   "${SCRIPTS_DIR}/mod_image_for_test.sh" --board=${FLAGS_board} \
     --image="$1/$2" --noinplace ${args}
 
   # From now on we use the just-created test image
   CHROMEOS_RETURN_VAL="$1/${CHROMEOS_TEST_IMAGE_NAME}"
 }
+
+# Check that the specified file exists.  If the file path is empty or the file
+# doesn't exist on the filesystem generate useful error messages.  Otherwise
+# show the user the name and path of the file that will be used.
+check_for_file() {
+  local name=$1
+  local padding=$2
+  local path=$3
+
+  if [ -z "${path}" ]; then
+    error "No ${name} file specified." && exit

[davidjames, 2011/03/01 00:09:49]

1. Looks like this is exiting with a success code. Shouldn't it exit with an
error code? Same comment below.
2. Should we just use 'die' instead if you want to exit?

[robotboy, 2011/03/01 00:20:19]

Done.

+  fi
+
+  if [ ! -e "${path}" ]; then
+    error "No ${name} file found at: ${path}" && exit
+  else
+    info "Using ${name}${padding}: ${path}"
+  fi
+}
+
+# Check that the specified tool exists.  If it does not exist in the PATH
+# generate a useful error message indicating how to install the ebuild
+# that contains the required tool.
+check_for_tool() {
+  local tool=$1
+  local ebuild=$2
+
+  if ! which "${tool}" >/dev/null ; then
+    error "The ${tool} utility was not found in your path.  Run the following"
+    error "command in your chroot to install it: sudo -E emerge ${ebuild}"
+    exit
+  fi
+}