Issue 6591052: Small cleanup for previous histogram checkin...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6591052: Small cleanup for previous histogram checkin... (Closed)

Created:
9 years, 9 months ago by jar (doing other things)

Modified:
9 years, 7 months ago

Reviewers:
commit-bot: I haz the power, rvargas (doing something else)

CC:
chromium-reviews, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Small cleanup for previous histogram checkin CL http://codereview.chromium.org/6577013/ had a few changes suggested that were not incorporated. This CL has those name changes etc. r=rvargas Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76345

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -15 lines)			Patch
M	base/metrics/histogram.h	View	1	3 chunks	+7 lines, -5 lines	0 comments	Download
M	base/metrics/histogram.cc	View	1	7 chunks	+10 lines, -9 lines	0 comments	Download
M	net/disk_cache/stats_histogram.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

jar (doing other things)

Please comment on the name change of Register() (you raised this issue in my previous ...

9 years, 9 months ago (2011-02-28 22:18:46 UTC) #1

rvargas (doing something else)

LGTM (but I guess StatsHistogram also has to be updated)

9 years, 9 months ago (2011-02-28 23:06:56 UTC) #2

jar (doing other things)

Added missing stats_histogram file to CL per comments by rvargas.

9 years, 9 months ago (2011-02-28 23:38:12 UTC) #3

Change committed as 76345