Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 6591051: Remove bzip2-encoded data file left behind when bzip2 support was removed in r34047. (Closed)

Created:
9 years, 9 months ago by adamk
Modified:
9 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove bzip2-encoded test data file left behind when bzip2 support was removed in r34047, as well as supporting code in testserver.py. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76603

Patch Set 1 #

Patch Set 2 : Remove related code from testserver.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, -73 lines) Patch
D net/data/filter_unittests/google.txt.bz2 View 0 chunks +-1 lines, --1 lines 0 comments Download
M net/tools/testserver/testserver.py View 1 2 chunks +0 lines, -74 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
adamk
9 years, 9 months ago (2011-02-28 22:05:59 UTC) #1
jar (doing other things)
LGTM.... but... be sure your trybots pass. bzip2 compression is still used in the metrics ...
9 years, 9 months ago (2011-02-28 22:32:50 UTC) #2
adamk
On Mon, Feb 28, 2011 at 2:32 PM, <jar@chromium.org> wrote: > LGTM.... but... be sure ...
9 years, 9 months ago (2011-02-28 22:36:40 UTC) #3
adamk
The reference to bzip you mentioned in net/base was in a comment and doesn't seem ...
9 years, 9 months ago (2011-03-01 00:17:44 UTC) #4
adamk
Jim, did you have any other comments here? If not, I plan to land this ...
9 years, 9 months ago (2011-03-02 18:47:01 UTC) #5
jar (doing other things)
Yes, the LGTM still stands... so you can land when ready.
9 years, 9 months ago (2011-03-02 19:51:20 UTC) #6
commit-bot: I haz the power
Try job failure for 6591051-4001 on mac: http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number=15243
9 years, 9 months ago (2011-03-02 19:54:35 UTC) #7
commit-bot: I haz the power
9 years, 9 months ago (2011-03-02 20:13:32 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698