Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6591002: Removed the command line from ServiceProcessState::AddToAutoRun() and had the... (Closed)

Created:
9 years, 10 months ago by sanjeevr
Modified:
9 years, 7 months ago
Reviewers:
dmaclach1, dmac, Scott Byer
CC:
chromium-reviews, brettw-cc_chromium.org, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Removed the command line from ServiceProcessState::AddToAutoRun() and had the class calculate its own command line. Wired up Linux autorun code and added unit tests. BUG=None TEST=Test service process autorun when enabling the cloud print proxy, unit-tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76077

Patch Set 1 #

Patch Set 2 : Linux build fix #

Patch Set 3 : Linux build fix really #

Total comments: 2

Patch Set 4 : Yet another Linux build fix #

Patch Set 5 : Code review comments addressed #

Patch Set 6 : '' #

Total comments: 4

Patch Set 7 : Scott's review comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -14 lines) Patch
M base/win/win_util.h View 1 chunk +5 lines, -0 lines 0 comments Download
M base/win/win_util.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/auto_start_linux.h View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/common/auto_start_linux.cc View 2 chunks +26 lines, -0 lines 0 comments Download
M chrome/common/service_process_util.h View 1 2 3 4 5 6 2 chunks +6 lines, -1 line 0 comments Download
M chrome/common/service_process_util.cc View 4 chunks +23 lines, -0 lines 0 comments Download
M chrome/common/service_process_util_linux.cc View 1 2 3 4 5 6 3 chunks +23 lines, -5 lines 0 comments Download
M chrome/common/service_process_util_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
chrome/common/service_process_util_unittest.cc View 1 2 3 4 2 chunks +59 lines, -0 lines 0 comments Download
M chrome/common/service_process_util_win.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/service/service_process.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/service_process.cc View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sanjeevr
9 years, 10 months ago (2011-02-25 03:17:08 UTC) #1
dmac
LGTM in general http://codereview.chromium.org/6591002/diff/16/chrome/common/service_process_util_unittest.cc File chrome/common/service_process_util_unittest.cc (right): http://codereview.chromium.org/6591002/diff/16/chrome/common/service_process_util_unittest.cc#newcode109 chrome/common/service_process_util_unittest.cc:109: ASSERT_TRUE(state->AddToAutoRun()); Can we do something to ...
9 years, 10 months ago (2011-02-25 03:56:22 UTC) #2
sanjeevr
http://codereview.chromium.org/6591002/diff/16/chrome/common/service_process_util_unittest.cc File chrome/common/service_process_util_unittest.cc (right): http://codereview.chromium.org/6591002/diff/16/chrome/common/service_process_util_unittest.cc#newcode109 chrome/common/service_process_util_unittest.cc:109: ASSERT_TRUE(state->AddToAutoRun()); On 2011/02/25 03:56:22, dmac wrote: > Can we ...
9 years, 10 months ago (2011-02-25 05:01:17 UTC) #3
dmaclach1
May be overkill, but you could create an object that did the clean up in ...
9 years, 9 months ago (2011-02-25 15:19:28 UTC) #4
Scott Byer
LGTM w/ nits On 2011/02/25 03:17:08, sanjeevr wrote:
9 years, 9 months ago (2011-02-25 18:11:22 UTC) #5
Scott Byer
http://codereview.chromium.org/6591002/diff/12006/chrome/common/service_process_util.h File chrome/common/service_process_util.h (right): http://codereview.chromium.org/6591002/diff/12006/chrome/common/service_process_util.h#newcode116 chrome/common/service_process_util.h:116: void CreateAutoRunCommandLine(); nit: space before member vars http://codereview.chromium.org/6591002/diff/12006/chrome/common/service_process_util_linux.cc File ...
9 years, 9 months ago (2011-02-25 18:19:23 UTC) #6
sanjeevr
9 years, 9 months ago (2011-02-25 18:22:55 UTC) #7 
http://codereview.chromium.org/6591002/diff/12006/chrome/common/service_proce...
File chrome/common/service_process_util.h (right):

http://codereview.chromium.org/6591002/diff/12006/chrome/common/service_proce...
chrome/common/service_process_util.h:116: void CreateAutoRunCommandLine();
On 2011/02/25 18:19:24, Scott Byer wrote:
> nit: space before member vars

Done.

http://codereview.chromium.org/6591002/diff/12006/chrome/common/service_proce...
File chrome/common/service_process_util_linux.cc (right):

http://codereview.chromium.org/6591002/diff/12006/chrome/common/service_proce...
chrome/common/service_process_util_linux.cc:84: "Chrome Service",
On 2011/02/25 18:19:24, Scott Byer wrote:
> Should be Chromium Service for non-official builds.

Done.

Powered by Google App Engine
This is Rietveld 408576698