Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 659002: Fix the build on Linux systems using PaX.... (Closed)

Created:
10 years, 10 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix the build on Linux systems using PaX. See http://code.google.com/p/v8/issues/detail?id=607

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M src/SConscript View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Paweł Hajdan Jr.
10 years, 10 months ago (2010-02-24 18:31:33 UTC) #1
sgk
lgtm
10 years, 10 months ago (2010-02-24 18:38:36 UTC) #2
Mads Ager (chromium)
LGTM, I'll land this for you.
10 years, 10 months ago (2010-02-24 18:41:08 UTC) #3
Mads Ager (chromium)
Landed in V8 bleeding_edge revision 3940. This will only fix the SConstruct build of course. ...
10 years, 10 months ago (2010-02-24 18:52:54 UTC) #4
Mads Ager (chromium)
10 years, 9 months ago (2010-02-25 08:28:20 UTC) #5
I reverted this change since it does not work on some versions of scons that we
are using.

It would be a nicer solution to detect somehow that we are on a system using PaX
and only attempt to execute this command if we are.  Can we do that?

Powered by Google App Engine
This is Rietveld 408576698