src/objects.cc - Issue 6588130: Handled return-value of SetElement in some cases, or avoided it in other.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 6588130: Handled return-value of SetElement in some cases, or avoided it in other. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge/build-ia32

Patch Set: Addressed review comments. Fixed some GetElements. Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 0b7f60a908f07f45efe0b2a48c26e1362f74a76d..0975a0364138bb6708a8326269ed9abeab90f425 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -6522,13 +6522,6 @@ void JSArray::Expand(int required_size) {

}

-// Computes the new capacity when expanding the elements of a JSObject.

-static int NewElementsCapacity(int old_capacity) {

- // (old_capacity + 50%) + 16

- return old_capacity + (old_capacity >> 1) + 16;

static Failure* ArrayLengthRangeError() {

HandleScope scope;

return Top::Throw(*Factory::NewRangeError("invalid_array_length",

« no previous file with comments | « src/objects.h ('k') | src/parser.cc » ('j') | no next file with comments »