Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Side by Side Diff: src/x64/codegen-x64.cc

Issue 6588116: Generalize fix for overflowing of the frame-element constant pool. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/virtual-frame-heavy-inl.h ('k') | src/x64/virtual-frame-x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 4678 matching lines...) Expand 10 before | Expand all | Expand 10 after
4689 } else { 4689 } else {
4690 ASSERT(var->is_global()); 4690 ASSERT(var->is_global());
4691 Reference ref(this, node); 4691 Reference ref(this, node);
4692 ref.GetValue(); 4692 ref.GetValue();
4693 } 4693 }
4694 } 4694 }
4695 4695
4696 4696
4697 void CodeGenerator::VisitLiteral(Literal* node) { 4697 void CodeGenerator::VisitLiteral(Literal* node) {
4698 Comment cmnt(masm_, "[ Literal"); 4698 Comment cmnt(masm_, "[ Literal");
4699 if (frame_->ConstantPoolOverflowed()) { 4699 frame_->Push(node->handle());
4700 Result temp = allocator_->Allocate();
4701 ASSERT(temp.is_valid());
4702 if (node->handle()->IsSmi()) {
4703 __ Move(temp.reg(), Smi::cast(*node->handle()));
4704 } else {
4705 __ movq(temp.reg(), node->handle(), RelocInfo::EMBEDDED_OBJECT);
4706 }
4707 frame_->Push(&temp);
4708 } else {
4709 frame_->Push(node->handle());
4710 }
4711 } 4700 }
4712 4701
4713 4702
4714 void CodeGenerator::LoadUnsafeSmi(Register target, Handle<Object> value) { 4703 void CodeGenerator::LoadUnsafeSmi(Register target, Handle<Object> value) {
4715 UNIMPLEMENTED(); 4704 UNIMPLEMENTED();
4716 // TODO(X64): Implement security policy for loads of smis. 4705 // TODO(X64): Implement security policy for loads of smis.
4717 } 4706 }
4718 4707
4719 4708
4720 bool CodeGenerator::IsUnsafeSmi(Handle<Object> value) { 4709 bool CodeGenerator::IsUnsafeSmi(Handle<Object> value) {
(...skipping 4116 matching lines...) Expand 10 before | Expand all | Expand 10 after
8837 } 8826 }
8838 8827
8839 #endif 8828 #endif
8840 8829
8841 8830
8842 #undef __ 8831 #undef __
8843 8832
8844 } } // namespace v8::internal 8833 } } // namespace v8::internal
8845 8834
8846 #endif // V8_TARGET_ARCH_X64 8835 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/virtual-frame-heavy-inl.h ('k') | src/x64/virtual-frame-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698