Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Side by Side Diff: src/virtual-frame-heavy-inl.h

Issue 6588116: Generalize fix for overflowing of the frame-element constant pool. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/virtual-frame-ia32.cc ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 elements_.Add(element); 80 elements_.Add(element);
81 } 81 }
82 } 82 }
83 83
84 84
85 bool VirtualFrame::ConstantPoolOverflowed() { 85 bool VirtualFrame::ConstantPoolOverflowed() {
86 return FrameElement::ConstantPoolOverflowed(); 86 return FrameElement::ConstantPoolOverflowed();
87 } 87 }
88 88
89 89
90 void VirtualFrame::Push(Handle<Object> value) {
91 ASSERT(!ConstantPoolOverflowed());
92 FrameElement element =
93 FrameElement::ConstantElement(value, FrameElement::NOT_SYNCED);
94 elements_.Add(element);
95 }
96
97
98 bool VirtualFrame::Equals(VirtualFrame* other) { 90 bool VirtualFrame::Equals(VirtualFrame* other) {
99 #ifdef DEBUG 91 #ifdef DEBUG
100 for (int i = 0; i < RegisterAllocator::kNumRegisters; i++) { 92 for (int i = 0; i < RegisterAllocator::kNumRegisters; i++) {
101 if (register_location(i) != other->register_location(i)) { 93 if (register_location(i) != other->register_location(i)) {
102 return false; 94 return false;
103 } 95 }
104 } 96 }
105 if (element_count() != other->element_count()) return false; 97 if (element_count() != other->element_count()) return false;
106 #endif 98 #endif
107 if (stack_pointer_ != other->stack_pointer_) return false; 99 if (stack_pointer_ != other->stack_pointer_) return false;
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 } 181 }
190 182
191 183
192 int VirtualFrame::local_count() { 184 int VirtualFrame::local_count() {
193 return cgen()->scope()->num_stack_slots(); 185 return cgen()->scope()->num_stack_slots();
194 } 186 }
195 187
196 } } // namespace v8::internal 188 } } // namespace v8::internal
197 189
198 #endif // V8_VIRTUAL_FRAME_HEAVY_INL_H_ 190 #endif // V8_VIRTUAL_FRAME_HEAVY_INL_H_
OLDNEW
« no previous file with comments | « src/ia32/virtual-frame-ia32.cc ('k') | src/x64/codegen-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698