Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 6588083: Add lazy deoptimization environment to instanceof by marking it as a call.... (Closed)

Created:
9 years, 9 months ago by fschneider
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add lazy deoptimization environment to instanceof by marking it as a call. This fixes an assert when an exception is thrown inside instanceof. BUG=v8:1207 TEST=mjsunit/regress/regress-1207.js Committed: http://code.google.com/p/v8/source/detail?r=6999

Patch Set 1 #

Patch Set 2 : added other platforms #

Patch Set 3 : removed unnecessary restore of context on ARM. #

Total comments: 1

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -20 lines) Patch
M src/arm/lithium-arm.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 1 chunk +1 line, -5 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +1 line, -6 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +1 line, -3 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
A test/mjsunit/regress/regress-1207.js View 1 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
fschneider
9 years, 9 months ago (2011-03-01 13:40:55 UTC) #1
Kevin Millikin (Chromium)
Drive bys: Does this need to be ported to the other platforms so the test ...
9 years, 9 months ago (2011-03-01 13:53:25 UTC) #2
Søren Thygesen Gjesse
LGTM
9 years, 9 months ago (2011-03-01 14:21:40 UTC) #3
fschneider
Uploaded x64 and ARM code. Please have a look at the new files.
9 years, 9 months ago (2011-03-01 14:39:59 UTC) #4
fschneider
On 2011/03/01 13:53:25, Kevin Millikin wrote: > Drive bys: > > Does this need to ...
9 years, 9 months ago (2011-03-01 14:40:21 UTC) #5
Søren Thygesen Gjesse
9 years, 9 months ago (2011-03-01 14:40:22 UTC) #6
LGTM for x64 and ARM as well.

http://codereview.chromium.org/6588083/diff/5003/src/x64/lithium-x64.cc
File src/x64/lithium-x64.cc (right):

http://codereview.chromium.org/6588083/diff/5003/src/x64/lithium-x64.cc#newco...
src/x64/lithium-x64.cc:1162: return MarkAsCall(DefineFixed(result, rax),
instr);;
Two ;s

Powered by Google App Engine
This is Rietveld 408576698