Issue 6588059: jimhebert -> watch for kernel boot param changes so I can maintain tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6588059: jimhebert -> watch for kernel boot param changes so I can maintain tests. (Closed)

Created:
9 years, 9 months ago by jimhebert

Modified:
9 years, 7 months ago

Reviewers:
Mandeep Singh Baines, anush, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/crosutils.git@master

Visibility:
Public.

Description

jimhebert -> watch for kernel boot param changes so I can maintain tests. Change-Id: I6a7b6c9ecb4380abb99df9cc12d29d975eb913db BUG=chromium-os:12582 TEST=none STATUS=Fixed Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=5d18402

Patch Set 1 #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	WATCHLISTS	View		1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

LGTM ... but test with depot_tools/watchlist.py to make sure you end up on the watchlist

9 years, 9 months ago (2011-02-28 21:04:38 UTC) #2

Mandeep Singh Baines

9 years, 9 months ago (2011-03-01 18:13:00 UTC) #3

LGTM

jimhebert@chromium.org (jimhebert@chromium.org) wrote:
> Reviewers: sosa, Mandeep Singh Baines, anush,
> 
> Description:
> jimhebert -> watch for kernel boot param changes so I can maintain tests.
> 
> Change-Id: I6a7b6c9ecb4380abb99df9cc12d29d975eb913db
> 
> BUG=chromium-os:12582
> TEST=none
> STATUS=Fixed
> 
> Please review this at http://codereview.chromium.org/6588059/
> 
> SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils.git@master
> 
> Affected files:
>   M WATCHLISTS
> 
> 
> Index: WATCHLISTS
> diff --git a/WATCHLISTS b/WATCHLISTS
> index
f7b2ac686f1da5017d8985fc2e6af01349654923..96278f8f9ad58c4fb53ba517c30f5bb6c9ebfc77
> 100644
> --- a/WATCHLISTS
> +++ b/WATCHLISTS
> @@ -7,9 +7,13 @@
>      'all': {
>        'filepath': '.',
>      },
> +    'build_kernel_image': {
> +      'filepath': 'build_kernel_image\.sh',
> +    },
>    },
>    'WATCHLISTS': {
>      'all': ['sosa@chromium.org', 'msb@chromium.org',
> -	    'anush@chromium.org']
> +	    'anush@chromium.org'],
> +    'build_kernel_image': ['jimhebert@chromium.org'],
>    },
>  }
> 
>

Expand Messages | Collapse Messages