Issue 6588053: Initial landing of file_manager component extension (not yet enabled)

Issue 6588053: Initial landing of file_manager component extension (not yet enabled) (Closed)

Created:
9 years, 9 months ago by rginda

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman, arv (Not doing code reviews), zel

CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, arv (Not doing code reviews), pam+watch_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Initial landing of file_manager component extension (not yet enabled) This is the initial landing of a component extension to handle file open, save-as, and file management user interfaces. This is just the basic plumbing, minus any useful functionality. I've tested this by building with... $ export GYP_DEFINES='file_manager_extension=1' $ make chrome -j16 Then launch the result and visit chrome-extension://hhaomjibdihmijegdhdafkllkbggdgoj/main.html, and verify that the <h1> tab is blue, and the document contains "Hello World". BUG=chromium-os:11988 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76408

Patch Set 1 #

Total comments: 5

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -0 lines)			Patch
M	build/common.gypi	View	5 chunks	+12 lines, -0 lines	1 comment	Download
M	chrome/browser/browser_resources.grd	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/profiles/profile_impl.cc	View	1 chunk	+6 lines, -0 lines	1 comment	Download
M	chrome/browser/resources/component_extension_resources.grd	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/file_manager/css/file_manager.css	View	1 chunk	+8 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/file_manager/images/icon16.png	View	Binary file		0 comments	Download
A	chrome/browser/resources/file_manager/js/file_manager.js	View	1 chunk	+7 lines, -0 lines	0 comments	Download
A	chrome/browser/resources/file_manager/main.html	View	1 chunk	+21 lines, -0 lines	3 comments	Download
A	chrome/browser/resources/file_manager/manifest.json	View	1 chunk	+13 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

zel

http://codereview.chromium.org/6588053/diff/1/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/6588053/diff/1/build/common.gypi#newcode28 build/common.gypi:28: 'file_manager_extension%': 0, I wouldn't create another build flag since ...

9 years, 9 months ago (2011-02-28 18:41:23 UTC) #2

rginda

On 2011/02/28 18:41:23, zel wrote: > http://codereview.chromium.org/6588053/diff/1/build/common.gypi > File build/common.gypi (right): > > http://codereview.chromium.org/6588053/diff/1/build/common.gypi#newcode28 > ...

9 years, 9 months ago (2011-02-28 18:48:03 UTC) #3

arv (Not doing code reviews)

LGTM I'm fine with having a specific flag for this but I'll let Zel make ...

9 years, 9 months ago (2011-02-28 19:40:20 UTC) #4

LGTM

Expand Messages | Collapse Messages