Issue 6585001: Expand comment for named IPC chmod().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6585001: Expand comment for named IPC chmod(). (Closed)

Created:
9 years, 10 months ago by dtu

Modified:
9 years, 7 months ago

Reviewers:
Wez

CC:
chromium-reviews, pam+watch_chromium.org, darin-cc_chromium.org, jam, dmac

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Description

Expand comment for named IPC chmod(). It was previously unclear that it is just a precaution and not intended to be a complete security policy for the named IPC channel. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76083

Patch Set 1 #

Total comments: 1

Patch Set 2 : wez #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -2 lines)			Patch
	M	ipc/ipc_channel_posix.cc	View	1	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Wez

http://codereview.chromium.org/6585001/diff/1/ipc/ipc_channel_posix.cc File ipc/ipc_channel_posix.cc (right): http://codereview.chromium.org/6585001/diff/1/ipc/ipc_channel_posix.cc#newcode196 ipc/ipc_channel_posix.cc:196: // Adjust the socket permissions as a precaution on ...

9 years, 10 months ago (2011-02-25 10:23:14 UTC) #2

Oh, missed this; besides nit-picking:

LGTM

Expand Messages | Collapse Messages