Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 6581045: Fix a ChromeFrame crash which occurs in the field typically during upgrades w... (Closed)

Created:
9 years, 10 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit, robertshield
CC:
chromium-reviews, amit
Visibility:
Public.

Description

Fix a ChromeFrame crash which occurs in the field typically during upgrades when multiple ChromeFrame versions are loaded in IE. We have code in ChromeFrame which attempts to fallback to the older version in case it is already loaded. This is done by creating a named shared memory block which contains the version of the loaded dll. Newer versions look at this block and fallback to the older version if any. However due to a small oversight this never worked as the shared memory block was created unnamed. Thus the fallbacks never occurred leading to multiple chrome frame binaries attempting to patch urlmon, etc. Fixes bug http://code.google.com/p/chromium/issues/detail?id=74047 BUG=74047 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75969

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome_frame/dll_redirector.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
9 years, 10 months ago (2011-02-24 20:31:20 UTC) #1
robertshield
On 2011/02/24 20:31:20, ananta wrote: LGTM
9 years, 10 months ago (2011-02-24 20:36:22 UTC) #2
amit
9 years, 10 months ago (2011-02-24 21:26:02 UTC) #3
lg

On Thu, Feb 24, 2011 at 12:36 PM, <robertshield@chromium.org> wrote:

> On 2011/02/24 20:31:20, ananta wrote:
>
> LGTM
>
>
> http://codereview.chromium.org/6581045/
>

Powered by Google App Engine
This is Rietveld 408576698