Add first changes needed for OWNERS file support.

tests/presubmit_unittest.py

 #!/usr/bin/python
 # Copyright (c) 2010 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for presubmit_support.py and presubmit_canned_checks.py."""
 
 # pylint is too confused.
 # pylint: disable=E1101,E1103,W0212,W0403
 
@@ skipping 79 matching lines @@
  this is line number 45
 +
  this is line number 46
  this is line number 47
 -this is line number 48
 +this is line number 48.1
  this is line number 49
 """
 
   def setUp(self):
+    class FakeChange(object):
+      root = '/'
+
+      def RepositoryRoot(self):
+        return self.root
+
     SuperMoxTestBase.setUp(self)
+    self.fake_change = FakeChange()
     self.mox.StubOutWithMock(presubmit, 'random')
     self.mox.StubOutWithMock(presubmit, 'warn')
     presubmit._ASKED_FOR_FEEDBACK = False
     self.fake_root_dir = self.RootDir()
     # Special mocks.
     def MockAbsPath(f):
       return f
     def MockChdir(f):
       return None
     # SuperMoxTestBase already mock these but simplify our life.
@@ skipping 15 matching lines @@
   def testMembersChanged(self):
     self.mox.ReplayAll()
     members = [
       'AffectedFile', 'Change', 'DoGetTrySlaves', 'DoPresubmitChecks',
       'GetTrySlavesExecuter', 'GitAffectedFile', 'GitChange',
       'InputApi', 'ListRelevantPresubmitFiles', 'Main',
       'NotImplementedException', 'OutputApi', 'ParseFiles',
       'PresubmitExecuter', 'PromptYesNo', 'ScanSubDirs',
       'SvnAffectedFile', 'SvnChange', 'cPickle', 'cStringIO',
       'exceptions', 'fnmatch', 'gclient_utils', 'glob', 'json',
-      'logging', 'marshal', 'normpath', 'optparse', 'os', 'pickle',
+      'logging', 'marshal', 'normpath', 'optparse', 'os', 'owners', 'pickle',
       'presubmit_canned_checks', 'random', 're', 'scm', 'subprocess',
       'sys', 'tempfile', 'time', 'traceback', 'types', 'unittest', 'urllib2',
       'warn',
     ]
     # If this test fails, you should add the relevant test.
     self.compareMembers(presubmit, members)
 
   def testListRelevantPresubmitFiles(self):
     join = presubmit.os.path.join
     files = [
@@ skipping 538 matching lines @@
   def testMembersChanged(self):
     self.mox.ReplayAll()
     members = [
       'AbsoluteLocalPaths', 'AffectedFiles', 'AffectedSourceFiles',
       'AffectedTextFiles',
       'DEFAULT_BLACK_LIST', 'DEFAULT_WHITE_LIST',
       'DepotToLocalPath', 'FilterSourceFile', 'LocalPaths',
       'LocalToDepotPath',
       'PresubmitLocalPath', 'ReadFile', 'RightHandSideLines', 'ServerPaths',
       'basename', 'cPickle', 'cStringIO', 'canned_checks', 'change', 'environ',
-      'is_committing', 'json', 'marshal', 'os_path', 'pickle', 'platform',
-      'python_executable', 're', 'subprocess', 'tempfile', 'traceback',
-      'unittest', 'urllib2', 'version',
+      'is_committing', 'json', 'marshal', 'os_path', 'owners_db', 'pickle',
+      'platform', 'python_executable', 're', 'subprocess', 'tempfile',
+      'traceback', 'unittest', 'urllib2', 'version',
     ]
     # If this test fails, you should add the relevant test.
-    self.compareMembers(presubmit.InputApi(None, './.', False), members)
+    self.compareMembers(presubmit.InputApi(self.fake_change, './.', False),
+                        members)
 
   def testDepotToLocalPath(self):
     presubmit.scm.SVN.CaptureInfo('svn://foo/smurf').AndReturn(
         {'Path': 'prout'})
     presubmit.scm.SVN.CaptureInfo('svn:/foo/notfound/burp').AndReturn({})
     self.mox.ReplayAll()
 
-    path = presubmit.InputApi(None, './p', False).DepotToLocalPath(
+    path = presubmit.InputApi(self.fake_change, './p', False).DepotToLocalPath(
         'svn://foo/smurf')
     self.failUnless(path == 'prout')
-    path = presubmit.InputApi(None, './p', False).DepotToLocalPath(
+    path = presubmit.InputApi(self.fake_change, './p', False).DepotToLocalPath(
         'svn:/foo/notfound/burp')
     self.failUnless(path == None)
 
   def testLocalToDepotPath(self):
-    presubmit.scm.SVN.CaptureInfo('smurf').AndReturn({'URL':
-                                                               'svn://foo'})
+    presubmit.scm.SVN.CaptureInfo('smurf').AndReturn({'URL': 'svn://foo'})
     presubmit.scm.SVN.CaptureInfo('notfound-food').AndReturn({})
     self.mox.ReplayAll()
-
-    path = presubmit.InputApi(None, './p', False).LocalToDepotPath('smurf')
+    path = presubmit.InputApi(self.fake_change, './p', False).LocalToDepotPath(
+        'smurf')
     self.assertEqual(path, 'svn://foo')
-    path = presubmit.InputApi(None, './p', False).LocalToDepotPath(
+    path = presubmit.InputApi(self.fake_change, './p', False).LocalToDepotPath(
         'notfound-food')
     self.failUnless(path == None)
 
   def testInputApiConstruction(self):
     self.mox.ReplayAll()
-    # Fudge the change object, it's not used during construction anyway
-    api = presubmit.InputApi(change=42, presubmit_path='foo/path/PRESUBMIT.py',
+    api = presubmit.InputApi(self.fake_change,
+                             presubmit_path='foo/path/PRESUBMIT.py',
                              is_committing=False)
     self.assertEquals(api.PresubmitLocalPath(), 'foo/path')
-    self.assertEquals(api.change, 42)
+    self.assertEquals(api.change, self.fake_change)
 
   def testInputApiPresubmitScriptFiltering(self):
     join = presubmit.os.path.join
     description_lines = ('Hello there',
                          'this is a change',
                          'BUG=123',
                          ' STORY =http://foo/  \t',
                          'and some more regular text')
     files = [
       ['A', join('foo', 'blat.cc')],
@@ skipping 120 matching lines @@
           f('a/.git'),
           f('b.c/.git'),
           f('a/.git/bleh.py'),
           f('.git/bleh.py'),
         ],
         [
           # Expected.
         ],
       ),
     ]
-    input_api = presubmit.InputApi(None, './PRESUBMIT.py', False)
+    input_api = presubmit.InputApi(self.fake_change, './PRESUBMIT.py', False)
     self.mox.ReplayAll()
 
     self.assertEqual(len(input_api.DEFAULT_WHITE_LIST), 22)
     self.assertEqual(len(input_api.DEFAULT_BLACK_LIST), 9)
     for item in files:
       results = filter(input_api.FilterSourceFile, item[0])
       for i in range(len(results)):
         self.assertEquals(results[i].LocalPath(),
                           presubmit.normpath(item[1][i]))
       # Same number of expected results.
@@ skipping 271 matching lines @@
     self.failUnless(len(output) == 1)
     self.failUnless(files[0] == output[0])
 
 
 class GclChangeUnittest(PresubmitTestsBase):
   def testMembersChanged(self):
     members = [
         'AbsoluteLocalPaths', 'AffectedFiles', 'AffectedTextFiles',
         'DescriptionText', 'FullDescriptionText', 'LocalPaths', 'Name',
         'RepositoryRoot', 'RightHandSideLines', 'ServerPaths',
-        'issue', 'patchset', 'scm', 'tags',
+        'approvers', 'issue', 'patchset', 'scm', 'tags',
     ]
     # If this test fails, you should add the relevant test.
     self.mox.ReplayAll()
 
     change = presubmit.Change('foo', 'foo', self.fake_root_dir, [('M', 'AA')],
                               0, 0)
     self.compareMembers(change, members)
 
 
 class CannedChecksUnittest(PresubmitTestsBase):
@@ skipping 30 matching lines @@
       'CheckChangeLintsClean',
       'CheckChangeSvnEolStyle',
       'CheckLicense',
       'CheckSvnModifiedDirectories',
       'CheckSvnForCommonMimeTypes', 'CheckSvnProperty',
       'CheckDoNotSubmit',
       'CheckDoNotSubmitInDescription', 'CheckDoNotSubmitInFiles',
       'CheckLongLines', 'CheckTreeIsOpen', 'RunPythonUnitTests',
       'RunPylint',
       'CheckBuildbotPendingBuilds', 'CheckRietveldTryJobExecution',
+      'CheckOwners',
     ]
     # If this test fails, you should add the relevant test.
     self.compareMembers(presubmit_canned_checks, members)
 
   def DescriptionTest(self, check, description1, description2, error_type,
                       committing):
     change1 = presubmit.Change('foo1', description1, self.fake_root_dir, None,
                                0, 0)
     input_api1 = self.MockInputApi(change1, committing)
     change2 = presubmit.Change('foo2', description2, self.fake_root_dir, None,
@@ skipping 602 matching lines @@
     results = presubmit_canned_checks.CheckBuildbotPendingBuilds(
         input_api, presubmit.OutputApi, 'uurl', 2, ('foo'))
     self.assertEquals(len(results), 1)
     self.assertEquals(results[0].__class__,
         presubmit.OutputApi.PresubmitNotifyResult)
 
 
 if __name__ == '__main__':
   import unittest
   unittest.main()