Issue 6581029: X64: Port r6635 and r6659...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6581029: X64: Port r6635 and r6659... (Closed)

Created:
9 years, 10 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64: Port r6635 and r6659 r6635: Remove the redundant load on every context lookup. r6659: Do not compile the unreachable body of functions with illegal redeclarations. The crankshaft part of these changes are already ported. Committed: http://code.google.com/p/v8/source/detail?r=6929

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -60 lines)			Patch
	M	src/x64/full-codegen-x64.cc	View		3 chunks	+79 lines, -56 lines	0 comments	Download
	M	src/x64/macro-assembler-x64.cc	View	1 2	2 chunks	+16 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

Redirecting to whesse. Could this be related to the change in r6915?

9 years, 10 months ago (2011-02-24 08:53:15 UTC) #2

William Hesse

LGTM, with comments. http://codereview.chromium.org/6581029/diff/2002/src/x64/macro-assembler-x64.cc File src/x64/macro-assembler-x64.cc (right): http://codereview.chromium.org/6581029/diff/2002/src/x64/macro-assembler-x64.cc#newcode2537 src/x64/macro-assembler-x64.cc:2537: // cannot be allowed to destroy ...

9 years, 10 months ago (2011-02-24 10:32:14 UTC) #3

Søren Thygesen Gjesse

9 years, 10 months ago (2011-02-24 11:33:17 UTC) #4

http://codereview.chromium.org/6581029/diff/2002/src/x64/macro-assembler-x64.cc
File src/x64/macro-assembler-x64.cc (right):

http://codereview.chromium.org/6581029/diff/2002/src/x64/macro-assembler-x64....
src/x64/macro-assembler-x64.cc:2537: // cannot be allowed to destroy the context
in esi).
On 2011/02/24 10:32:15, William Hesse wrote:
> rsi, not esi.

Done.

Expand Messages | Collapse Messages