Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Issue 6581028: X64: Implement DoComputeOsrOutputFrame and fix Generate_OnStackReplacement.... (Closed)

Created:
9 years, 10 months ago by Rico
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

X64: Implement DoComputeOsrOutputFrame and fix Generate_OnStackReplacement. The existing version does not have a correct implementation of Generate_OnStackReplacement since we do not correctly find the loop depth. This is mainly because EmitStackCheck in full-codegen-x64.cc did not write it and partly due to us reading at the wrong offset (which had no effect when it was not written in the first place, we simply got a random number from the next instruction). The DoComputeOsrOoutputFrame is very similar to the ia32 version. Committed: http://code.google.com/p/v8/source/detail?r=6931

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -7 lines) Patch
M src/flag-definitions.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 2 chunks +143 lines, -3 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Rico
9 years, 10 months ago (2011-02-24 07:49:10 UTC) #1
Rico
Adding Florian as reviewer since Kevin is on vacation.
9 years, 10 months ago (2011-02-24 08:01:49 UTC) #2
Rico
Uploaded new version using testl instead of testq in EmitStackCheck (since this value will never ...
9 years, 10 months ago (2011-02-24 11:36:18 UTC) #3
fschneider
9 years, 10 months ago (2011-02-24 11:45:35 UTC) #4
LGTM.

Powered by Google App Engine
This is Rietveld 408576698