Fix progress event not firing when load has completed.

webkit/glue/webmediaplayer_impl.cc

Index: webkit/glue/webmediaplayer_impl.cc
diff --git a/webkit/glue/webmediaplayer_impl.cc b/webkit/glue/webmediaplayer_impl.cc
index 075439d4930f8312f3302487e9f0fb145ca33015..eefe7266436fcfd3e4179f8bcc13c57494dbf5da 100644
--- a/webkit/glue/webmediaplayer_impl.cc
+++ b/webkit/glue/webmediaplayer_impl.cc
@@ -825,8 +825,12 @@ void WebMediaPlayerImpl::OnNetworkEvent() {
       // If we are inactive because we just finished receiving all the data,
       // do one final repaint to show final progress.
       if (bytesLoaded() == totalBytes() &&
-          network_state_ != WebKit::WebMediaPlayer::Idle)
+          network_state_ != WebKit::WebMediaPlayer::Idle) {
         Repaint();
+      }
+      if (network_state_ == WebKit::WebMediaPlayer::Loading) {
+        SetNetworkState(WebKit::WebMediaPlayer::Loaded);

[acolwell GONE FROM CHROMIUM, 2011/02/24 19:19:08]

Shouldn't this be inside the condition with the Repaint()? Then you at least
know that you are transitioning when you have downloaded all the bytes.

[sjl, 2011/02/24 21:24:41]

Good point. Fixed.

+      }
       SetNetworkState(WebKit::WebMediaPlayer::Idle);

[acolwell GONE FROM CHROMIUM, 2011/02/24 19:19:08]

Why is there an immediate transition from Loaded to Idle?

[sjl, 2011/02/24 21:24:41]

We need to switch to idle when we've finished downloading and we're done with
network activity, but before that we need to transition through the loaded state
(which was being skipped previously). It's in this transition that webkit sends
out the final progress event (as per spec).

     }
   }