Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 6581004: Add command line switches and about:flag to enable FPS indicator and compositor layer tree. (Closed)

Created:
9 years, 10 months ago by nduca
Modified:
9 years, 3 months ago
Reviewers:
jamesr
CC:
chromium-reviews, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Add command line switches and about:flag to enable FPS indicator and compositor layer tree. Intentionally did not add a flag for compositor-layer-tree. Can add one if we feel it is truly useful. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=77163

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixes based on feedback #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +6 lines, -0 lines 1 comment Download
M chrome/browser/about_flags.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/common/render_messages.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nduca
9 years, 10 months ago (2011-02-23 21:00:04 UTC) #1
Vangelis Kokkevis
Looks good overall but needs a couple of adjustments as noted. http://codereview.chromium.org/6581004/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): ...
9 years, 10 months ago (2011-02-24 07:07:11 UTC) #2
nduca
http://codereview.chromium.org/6581004/diff/1/chrome/common/chrome_switches.cc File chrome/common/chrome_switches.cc (right): http://codereview.chromium.org/6581004/diff/1/chrome/common/chrome_switches.cc#newcode1116 chrome/common/chrome_switches.cc:1116: const char kShowFPSCounter[] = "show-fps-counter"; On 2011/02/24 07:07:11, Vangelis ...
9 years, 9 months ago (2011-03-03 20:04:06 UTC) #3
jamesr
9 years, 9 months ago (2011-03-04 19:31:04 UTC) #4
Please run through the trybots before landing.

LGTM

http://codereview.chromium.org/6581004/diff/6001/chrome/app/generated_resourc...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/6581004/diff/6001/chrome/app/generated_resourc...
chrome/app/generated_resources.grd:4059: <message
name="IDS_FLAGS_SHOW_FPS_COUNTER" desc="Name of the 'Show FPS counter lab.">
mismatched '

Powered by Google App Engine
This is Rietveld 408576698