Issue 658005: Bring Geolocation to life!...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 658005: Bring Geolocation to life!... (Closed)

Created:
10 years, 10 months ago by joth

Modified:
9 years, 7 months ago

Reviewers:
bulach

CC:
chromium-reviews, ben+cc_chromium.org, jorlow

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Bring Geolocation to life! Bolt the geolocation dispatcher host up to the location arbitrator Introduces a new method for fetching a singleton default location arbitrator with minimal fuss. Fix bug in the geolocation dispatcher where bridge id & route id were swapped on send. BUG=http://crbug.com/11246 TEST=run browser with --enable-geolocaiton & Open http://maps.google.co.uk/maps/m Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=40118

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Created: 10 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -51 lines)			Patch
M	chrome/browser/geolocation/geolocation_browsertest.cc	View		3 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_dispatcher_host.h	View	1	3 chunks	+9 lines, -4 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_dispatcher_host.cc	View	1	3 chunks	+10 lines, -11 lines	0 comments	Download
M	chrome/browser/geolocation/location_arbitrator.h	View	1	4 chunks	+20 lines, -9 lines	0 comments	Download
M	chrome/browser/geolocation/location_arbitrator.cc	View	1 2	7 chunks	+30 lines, -17 lines	0 comments	Download
M	chrome/browser/geolocation/location_arbitrator_unittest.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	chrome/renderer/geolocation_dispatcher.cc	View		1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages