Get property may throw an exception thanks to JS accessors.

Get property may throw an exception thanks to JS accessors.

Check result before and bail out if exception has been thrown.

BUG=v8:1172
TEST=test/mjsunit/regress/regress-1172-bis.js

Committed: http://code.google.com/p/v8/source/detail?r=6939

[antonm, 2011-02-24 15:47:58]

Mads and Martin,

tiny review for you.

[Martin Maly, 2011-02-24 17:33:49]

Thanks for fixing this, Anton. I remember wondering when I made the change from
Runtime::GetObjectProperty (returns MaybeObject*) to GetProperty (returhs
Handle<Object>) whether something may be different. Now re-reading
CALL_HEAP_FUNCTION it makes sense that on exception empty handle gets returned
which requires your code to propagate it out.

LGTM. Mads may want to double-check, although I am pretty sure this is the right
fix..

Thanks again
Martin

http://codereview.chromium.org/6580030/diff/1/src/ic.cc
File src/ic.cc (right):

http://codereview.chromium.org/6580030/diff/1/src/ic.cc#newcode807
src/ic.cc:807: RETURN_IF_EMPTY_HANDLE(result);
Of course ... with my recent change the exceptions were getting lost here.
Thanks for fixing it!