Implement ClientSocketFactory::ClearSSLSessionCache

net/socket/client_socket_factory.cc

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/socket/client_socket_factory.h"
 
 #include "base/lazy_instance.h"
 #include "build/build_config.h"
 #include "net/socket/client_socket_handle.h"
 #if defined(OS_WIN)
@@ skipping 75 matching lines @@
     const SSLConfig& ssl_config,
     SSLHostInfo* ssl_host_info,
     CertVerifier* cert_verifier) {
   ClientSocketHandle* socket_handle = new ClientSocketHandle();
   socket_handle->set_socket(transport_socket);
   return CreateSSLClientSocket(socket_handle, host_and_port, ssl_config,
                                ssl_host_info, cert_verifier,
                                NULL /* DnsCertProvenanceChecker */);
 }
 
+void ClientSocketFactory::ClearSSLSessionCache() {

[wtc, 2011/02/24 01:00:14]

This should be defined by the DefaultClientSocketFactory
class.  In the ClientSocketFactory class this should be
a pure virtual method (= 0).

[Ryan Hamilton, 2011/02/24 22:38:46]

Done.

+#if defined(OS_WIN)
+  if (!g_use_system_ssl) {
+    SSLClientSocketNSS::ClearSessionCache();
+  }

[wtc, 2011/02/24 01:00:14]

Nit: don't use curly braces {} around simple one-liner "if"
bodies.  Make the same change to lines 106-108 below.

[Ryan Hamilton, 2011/02/24 22:38:46]

Done!  Sorry about that!  GFE *requires* braces on one line "if"s, Chrome
rejects them.   So many standards to choose from :>

+#elif defined(USE_OPENSSL)
+  // no-op
+#elif defined(USE_NSS)
+  SSLClientSocketNSS::ClearSessionCache();
+#elif defined(OS_MACOSX)
+  if (!g_use_system_ssl) {
+    SSLClientSocketNSS::ClearSessionCache();
+  }
+#else
+  NOTIMPLEMENTED();
+  return NULL;

[wtc, 2011/02/24 01:00:14]

Bug: remove "return NULL;" because this function returns void.

[Ryan Hamilton, 2011/02/24 22:38:46]

Done.

+#endif
+}
+
 // static
 ClientSocketFactory* ClientSocketFactory::GetDefaultFactory() {
   return g_default_client_socket_factory.Pointer();
 }
 
 // static
 void ClientSocketFactory::UseSystemSSL() {
   g_use_system_ssl = true;
 }
 
 }  // namespace net