Issue 6579048: Reintroduce RunCommand cleanup and unit tests. Fixed previous issue, and

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6579048: Reintroduce RunCommand cleanup and unit tests. Fixed previous issue, and (Closed)

Created:
9 years, 10 months ago by dgarrett

Modified:
9 years, 7 months ago

Reviewers:
semenzato, sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Reintroduce RunCommand cleanup and unit tests. Fixed previous issue in which exceptions were thrown if exit_code was set, and added a new unittest to prove that. This reintroduces the change after commit 3635aaa55e194c496e11c1b74395646fb99c8801, which reverted 01c84235827527cd2f938897a4a8dfcdbf877281. BUG=chromium-os:11717 TEST=Ran new unit tests, and did full build. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e1b78a7

Patch Set 1 #

Patch Set 2 : Don't throw an exception if exit_code is True. #

Patch Set 3 : Remove bogus whitespace. #

Total comments: 1

Patch Set 4 : Fixup RunCommand DocString #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -17 lines)			Patch
	M	lib/cros_build_lib.py	View	1 2 3	2 chunks	+25 lines, -17 lines	0 comments	Download
	A	lib/cros_build_lib_unittest.py	View	1 2	1 chunk	+92 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dgarrett

The full build is still in progress, but going to go ahead and put this ...

9 years, 10 months ago (2011-02-24 23:52:55 UTC) #1

sosa

9 years, 9 months ago (2011-03-01 19:42:42 UTC) #3

LGTM w/ nit

http://codereview.chromium.org/6579048/diff/3001/lib/cros_build_lib.py
File lib/cros_build_lib.py (right):

http://codereview.chromium.org/6579048/diff/3001/lib/cros_build_lib.py#newcode39
lib/cros_build_lib.py:39: exit_code: returns the return code of the shell
command.
Update docsring perhaps to say returns exit code ... in case of non-zero exit
code does not throw exception

Expand Messages | Collapse Messages