Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1404)

Issue 6579026: PPB_Flash cleanup part 2: move all the file stuff to ppb_flash_file.*. (Closed)

Created:
9 years, 10 months ago by viettrungluu
Modified:
9 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews
Visibility:
Public.

Description

PPB_Flash cleanup part 2: move all the file stuff to ppb_flash_file.*. ppb_flash_file.* is intended to contain multiple (very similar) interfaces, of which the ModuleLocal stuff is one. BUG=none TEST="everything" still works Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75921

Patch Set 1 #

Patch Set 2 : alpha order fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+702 lines, -519 lines) Patch
M ppapi/c/private/ppb_flash.h View 3 chunks +1 line, -73 lines 0 comments Download
A ppapi/c/private/ppb_flash_file.h View 1 chunk +89 lines, -0 lines 0 comments Download
M ppapi/c/private/ppb_flash_net_connector.h View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/ppapi_shared_proxy.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/dispatcher.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M ppapi/proxy/interface_id.h View 1 chunk +1 line, -0 lines 0 comments Download
M ppapi/proxy/ppapi_messages_internal.h View 2 chunks +23 lines, -20 lines 0 comments Download
A ppapi/proxy/ppb_flash_file_proxy.h View 1 chunk +69 lines, -0 lines 0 comments Download
A ppapi/proxy/ppb_flash_file_proxy.cc View 1 chunk +284 lines, -0 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.h View 3 chunks +1 line, -28 lines 0 comments Download
M ppapi/proxy/ppb_flash_proxy.cc View 6 chunks +0 lines, -223 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A webkit/plugins/ppapi/ppb_flash_file_impl.h View 1 chunk +21 lines, -0 lines 0 comments Download
A webkit/plugins/ppapi/ppb_flash_file_impl.cc View 1 chunk +205 lines, -0 lines 0 comments Download
M webkit/plugins/ppapi/ppb_flash_impl.cc View 3 chunks +0 lines, -174 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
9 years, 10 months ago (2011-02-24 01:14:37 UTC) #1
piman
9 years, 10 months ago (2011-02-24 01:52:21 UTC) #2
LGTM

On Wed, Feb 23, 2011 at 5:14 PM, <viettrungluu@chromium.org> wrote:

> Reviewers: piman,
>
> Description:
> PPB_Flash cleanup part 2: move all the file stuff to ppb_flash_file.*.
>
> ppb_flash_file.* is intended to contain multiple (very similar) interfaces,
> of
> which the ModuleLocal stuff is one.
>
> BUG=none
> TEST="everything" still works
>
> Please review this at http://codereview.chromium.org/6579026/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M ppapi/c/private/ppb_flash.h
>  A ppapi/c/private/ppb_flash_file.h
>  M ppapi/c/private/ppb_flash_net_connector.h
>  M ppapi/ppapi_shared_proxy.gypi
>  M ppapi/proxy/dispatcher.cc
>  M ppapi/proxy/interface_id.h
>  M ppapi/proxy/ppapi_messages_internal.h
>  A ppapi/proxy/ppb_flash_file_proxy.h
>  A ppapi/proxy/ppb_flash_file_proxy.cc
>  M ppapi/proxy/ppb_flash_proxy.h
>  M ppapi/proxy/ppb_flash_proxy.cc
>  M webkit/glue/webkit_glue.gypi
>  A webkit/plugins/ppapi/ppb_flash_file_impl.h
>  A webkit/plugins/ppapi/ppb_flash_file_impl.cc
>  M webkit/plugins/ppapi/ppb_flash_impl.cc
>
>
>

Powered by Google App Engine
This is Rietveld 408576698