Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(557)

Issue 6579018: Pepper: Increment the version numbers for PPB_{FileRef,FileSystem}_Dev. (Closed)

Created:
9 years, 10 months ago by viettrungluu
Modified:
9 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews
Visibility:
Public.

Description

Pepper: Increment the version numbers for PPB_{FileRef,FileSystem}_Dev. The PP_FileSystemType_Dev enum was changed in r75566, implicitly changing these interfaces (whose revision numbers weren't changed). BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75806

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ppapi/c/dev/ppb_file_ref_dev.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/c/dev/ppb_file_system_dev.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
viettrungluu
9 years, 10 months ago (2011-02-23 22:36:12 UTC) #1
piman
9 years, 10 months ago (2011-02-23 22:37:22 UTC) #2
LGTM

On Wed, Feb 23, 2011 at 2:36 PM, <viettrungluu@chromium.org> wrote:

> Reviewers: piman,
>
> Description:
> Pepper: Increment the version numbers for PPB_{FileRef,FileSystem}_Dev.
>
> The PP_FileSystemType_Dev enum was changed in r75566, implicitly changing
> these
> interfaces (whose revision numbers weren't changed).
>
> BUG=none
> TEST=none
>
> Please review this at http://codereview.chromium.org/6579018/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>  M ppapi/c/dev/ppb_file_ref_dev.h
>  M ppapi/c/dev/ppb_file_system_dev.h
>
>
> Index: ppapi/c/dev/ppb_file_ref_dev.h
> diff --git a/ppapi/c/dev/ppb_file_ref_dev.h
> b/ppapi/c/dev/ppb_file_ref_dev.h
> index
>
24cb21d82e4617d343142beb70503f4bd83ded03..fe865adc0f4292f8f16b88da7c8413764b1c6036
> 100644
> --- a/ppapi/c/dev/ppb_file_ref_dev.h
> +++ b/ppapi/c/dev/ppb_file_ref_dev.h
> @@ -1,4 +1,4 @@
> -/* Copyright (c) 2010 The Chromium Authors. All rights reserved.
> +/* Copyright (c) 2011 The Chromium Authors. All rights reserved.
>  * Use of this source code is governed by a BSD-style license that can be
>  * found in the LICENSE file.
>  */
> @@ -11,7 +11,7 @@
>  #include "ppapi/c/pp_resource.h"
>  #include "ppapi/c/pp_var.h"
>
> -#define PPB_FILEREF_DEV_INTERFACE "PPB_FileRef(Dev);0.6"
> +#define PPB_FILEREF_DEV_INTERFACE "PPB_FileRef(Dev);0.7"
>
>  // A FileRef is a "weak pointer" to a file in a file system.  It contains
> a
>  // PP_FileSystemType identifier and a file path string.
> Index: ppapi/c/dev/ppb_file_system_dev.h
> diff --git a/ppapi/c/dev/ppb_file_system_dev.h
> b/ppapi/c/dev/ppb_file_system_dev.h
> index
>
768c35f38f67d072674a6fa350acd1deda2ea650..213971278d2bcf82e875d42321feece1f79db874
> 100644
> --- a/ppapi/c/dev/ppb_file_system_dev.h
> +++ b/ppapi/c/dev/ppb_file_system_dev.h
> @@ -14,7 +14,7 @@
>
>  struct PP_CompletionCallback;
>
> -#define PPB_FILESYSTEM_DEV_INTERFACE "PPB_FileSystem(Dev);0.4"
> +#define PPB_FILESYSTEM_DEV_INTERFACE "PPB_FileSystem(Dev);0.5"
>
>  struct PPB_FileSystem_Dev {
>   /** Creates a filesystem object of the given type. */
>
>
>

Powered by Google App Engine
This is Rietveld 408576698