Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 6579008: Don't install python shell script, as we now want to fall thru to cygwin.... (Closed)

Created:
9 years, 10 months ago by bradn
Modified:
9 years, 7 months ago
CC:
chromium-reviews, M-A Ruel
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/tools/depot_tools/
Visibility:
Public.

Description

Don't install python shell script, as we now want to fall thru to cygwin. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75789

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -12 lines) Patch
D bootstrap/win/python.new View 1 chunk +0 lines, -5 lines 0 comments Download
D bootstrap/win/svn.new View 1 chunk +0 lines, -5 lines 0 comments Download
M bootstrap/win/win_tools.bat View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
bradn
9 years, 10 months ago (2011-02-23 21:18:58 UTC) #1
M-A Ruel
lgtm let's see the world auto-destroy. :)
9 years, 10 months ago (2011-02-23 21:21:24 UTC) #2
nsylvain
Just noticed that this is actually breaking the bots because they call out to depot_tools/svn ...
9 years, 9 months ago (2011-03-03 00:56:07 UTC) #3
Peter Kasting
On 2011/03/03 00:56:07, nsylvain wrote: > I can most likely fix the scripts on the ...
9 years, 9 months ago (2011-03-03 01:00:15 UTC) #4
nsylvain
9 years, 9 months ago (2011-03-03 01:05:55 UTC) #5
On Wed, Mar 2, 2011 at 5:00 PM, <pkasting@chromium.org> wrote:

> On 2011/03/03 00:56:07, nsylvain wrote:
>
>> I can most likely fix the scripts on the bots to call svn.bat directly,
>> but
>>
> I'm
>
>> curious as why this change was made.  Is python/svn in cygwin not evil?
>>
>
> It is not evil, whereas running the non-cygwin python/svn are very evil.
>  They
> are much slower and don't interact well with the shell/console.

Ok, I guess your use case is different.  on the bots we use the command
prompt (with normal svn) 98% of the
time, but once in a while we need to use cygwin to run more complex scripts,
and if we use the cygwin svn there, it
might screw up our use of the normal svn later on.

But... I just convinced myself that the right thing to do is to force my
script to use svn.bat, as I'm the one with the weird use case.

Nicolas


>
>
> http://codereview.chromium.org/6579008/
>

Powered by Google App Engine
This is Rietveld 408576698