Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: chrome/browser/chromeos/webui/login/login_ui_helpers.h

Issue 6579003: Add in chrome://login-container (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: changes made in response to Oshima's and Nikita's comments Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_WEBUI_LOGIN_LOGIN_UI_HELPERS_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_WEBUI_LOGIN_LOGIN_UI_HELPERS_H_
6 #define CHROME_BROWSER_CHROMEOS_WEBUI_LOGIN_LOGIN_UI_HELPERS_H_ 6 #define CHROME_BROWSER_CHROMEOS_WEBUI_LOGIN_LOGIN_UI_HELPERS_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
11 #include "base/string_piece.h"
12
11 class Browser; 13 class Browser;
12 class DictionaryValue; 14 class DictionaryValue;
13 class FilePath; 15 class FilePath;
14 class Profile; 16 class Profile;
15 class RefCountedBytes; 17 class RefCountedBytes;
16 18
17 namespace base { 19 namespace base {
18 class StringPiece; 20 class StringPiece;
19 }; // namespace base 21 }; // namespace base
oshima 2011/02/28 20:33:09 remove this.
rharrison 2011/02/28 20:38:14 Done.
20 22
21 namespace chromeos { 23 namespace chromeos {
22 24
23 // This class is used for encapsulating the statics and other other messy 25 // This class is used for encapsulating the statics and other other messy
24 // external calls that are required for getting the needed profile objects. This 26 // external calls that are required for getting the needed profile objects. This
25 // allows for easier mocking of this code and allows for modularity. 27 // allows for easier mocking of this code and allows for modularity.
26 class ProfileOperationsInterface { 28 class ProfileOperationsInterface {
27 public: 29 public:
28 ProfileOperationsInterface() {} 30 ProfileOperationsInterface() {}
29 virtual ~ProfileOperationsInterface() {} 31 virtual ~ProfileOperationsInterface() {}
(...skipping 28 matching lines...) Expand all
58 // external calls that are required for creating and getting the needed HTML 60 // external calls that are required for creating and getting the needed HTML
59 // objects. This allows for easier mocking of this code and allows for 61 // objects. This allows for easier mocking of this code and allows for
60 // modularity. Since we don't currently unit the class that this code is related 62 // modularity. Since we don't currently unit the class that this code is related
61 // to, there is a case for refactoring it back into LoginUIHTMLSource. 63 // to, there is a case for refactoring it back into LoginUIHTMLSource.
62 class HTMLOperationsInterface { 64 class HTMLOperationsInterface {
63 public: 65 public:
64 HTMLOperationsInterface() {} 66 HTMLOperationsInterface() {}
65 virtual ~HTMLOperationsInterface() {} 67 virtual ~HTMLOperationsInterface() {}
66 68
67 virtual base::StringPiece GetLoginHTML(); 69 virtual base::StringPiece GetLoginHTML();
70 virtual base::StringPiece GetLoginContainerHTML();
68 virtual std::string GetFullHTML(base::StringPiece login_html, 71 virtual std::string GetFullHTML(base::StringPiece login_html,
69 DictionaryValue* localized_strings); 72 DictionaryValue* localized_strings);
70 virtual RefCountedBytes* CreateHTMLBytes(std::string full_html); 73 virtual RefCountedBytes* CreateHTMLBytes(std::string full_html);
71 74
72 private: 75 private:
73 DISALLOW_COPY_AND_ASSIGN(HTMLOperationsInterface); 76 DISALLOW_COPY_AND_ASSIGN(HTMLOperationsInterface);
74 }; 77 };
75 78
76 } // namespace chromeos 79 } // namespace chromeos
77 80
78 #endif // CHROME_BROWSER_CHROMEOS_WEBUI_LOGIN_LOGIN_UI_HELPERS_H_ 81 #endif // CHROME_BROWSER_CHROMEOS_WEBUI_LOGIN_LOGIN_UI_HELPERS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698