Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Issue 6578003: Add back U_WCHAR_IS_UTF32 macro to pmac.h... (Closed)

Created:
9 years, 10 months ago by jungshik at Google
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews, jshin+watch_chromium.org
Visibility:
Public.

Description

Add back U_WCHAR_IS_UTF32 macro to pmac.h That was accidentally dropped when upgrading to ICU 4.6. That leads to a failure in ICUStringConversionsTest.ConvertCodepageUTF8 on Mac. __STDC_ISO_10646__ is not defined on Mac. Neither is _UCS_4. So, u_strFromWCS ends up calling wcstombs on Mac instead of u_strFromUTF32. I'm gonna change WideToCodepage in base/i18n/icu_string*.cc to use u_strFromUTF32 directly. However, there might be other places where the absence of U_WCHAR_IS_UTF32 can lead to a problem. To be safe, I'm adding back this to pmac.h BUG=61514 TEST=With this version of ICU 4.6 pulled in, all the tests pass including 'base_unittests --gtest_filter=ICU*.Conv*' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=75773

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -4 lines) Patch
M third_party/icu/patches/pmac.h.patch View 2 chunks +21 lines, -4 lines 0 comments Download
M third_party/icu/public/common/unicode/pmac.h View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jungshik at Google
9 years, 10 months ago (2011-02-23 18:53:40 UTC) #1
Mark Mentovai
9 years, 10 months ago (2011-02-23 18:54:54 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698