Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Unified Diff: base/metrics/field_trial.cc

Issue 6577038: Minor fixes in FieldTrial. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/metrics/field_trial.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/metrics/field_trial.cc
diff --git a/base/metrics/field_trial.cc b/base/metrics/field_trial.cc
index fceccde272ab8f0029807f5fa1fa5c9c8e3b9910..c1416dbce2e80a61bc188104c49780c82b9b57c2 100644
--- a/base/metrics/field_trial.cc
+++ b/base/metrics/field_trial.cc
@@ -41,6 +41,7 @@ FieldTrial::FieldTrial(const std::string& name,
accumulated_group_probability_(0),
next_group_number_(kDefaultGroupNumber+1),
group_(kNotFinalized) {
+ DCHECK_GT(total_probability, 0);
DCHECK(!default_group_name_.empty());
FieldTrialList::Register(this);
@@ -53,7 +54,7 @@ FieldTrial::FieldTrial(const std::string& name,
base::Time::Exploded exploded;
exploded.year = year;
exploded.month = month;
- exploded.day_of_week = 0; // Should be unusued.
+ exploded.day_of_week = 0; // Should be unused.
exploded.day_of_month = day_of_month;
exploded.hour = 0;
exploded.minute = 0;
« no previous file with comments | « base/metrics/field_trial.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698