Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 6577029: web-ui settings: Explicitly set preferences for sans-serif font and minimum l... (Closed)

Created:
9 years, 10 months ago by csilv
Modified:
9 years, 7 months ago
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

web-ui settings: Explicitly set preferences for sans-serif font and minimum logical font size. BUG=73842 TEST=Verify that changing fonts and minimum font size results in correct preferences set in the 'Preferences' file. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76141

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -71 lines) Patch
M chrome/browser/resources/options/font_settings.html View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/font_settings.js View 2 chunks +27 lines, -1 line 0 comments Download
D chrome/browser/resources/options/font_settings_ui.js View 1 chunk +0 lines, -66 lines 0 comments Download
M chrome/browser/resources/options/options.html View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/options/pref_ui.js View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
csilv
+jhawkins, arv for review.
9 years, 10 months ago (2011-02-24 23:22:13 UTC) #1
arv (Not doing code reviews)
LGTM
9 years, 10 months ago (2011-02-24 23:48:32 UTC) #2
csilv
+kochi for review
9 years, 10 months ago (2011-02-24 23:58:06 UTC) #3
kochi
LGTM Okay for setting from one UI to serif and sans-serif at this point. With ...
9 years, 10 months ago (2011-02-25 04:46:48 UTC) #4
James Hawkins
9 years, 10 months ago (2011-02-26 02:17:00 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld 408576698