Issue 6577014: Added some documentation to the CrashTest class.

Issue 6577014: Added some documentation to the CrashTest class. (Closed)

Created:
9 years, 10 months ago by sjg

Modified:
9 years, 7 months ago

Reviewers:
kmixter1

CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli

Base URL:
ssh://git@gitrw.chromium.org:9222/autotest.git@master

Visibility:
Public.

Description

Added some documentation to the CrashTest class. BUG=chromium-os:12454 TEST=./run_remote_tests.sh --remote=seaboard0 UserCrash Change-Id: I0a104b4056972d1b235284514cb220edc4bdf0bf Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=a47f0d7

Patch Set 1 #

Total comments: 3

Patch Set 2 : Removed extra comment #

Patch Set 3 : Test before push #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -9 lines)			Patch
	M	client/cros/crash_test.py	View	1 2	18 chunks	+194 lines, -8 lines	0 comments	Download
	M	client/site_tests/logging_CrashSender/logging_CrashSender.py	View	1	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kmixter1

LGTM - Thanks for adding comments. http://codereview.chromium.org/6577014/diff/1/client/cros/crash_test.py File client/cros/crash_test.py (right): http://codereview.chromium.org/6577014/diff/1/client/cros/crash_test.py#newcode15 client/cros/crash_test.py:15: machine and generate ...

9 years, 10 months ago (2011-02-25 00:15:15 UTC) #2

sjg

9 years, 9 months ago (2011-03-01 01:09:09 UTC) #3

On 2011/02/25 00:15:15, kmixter1 wrote:
> LGTM - Thanks for adding comments.
> 
> http://codereview.chromium.org/6577014/diff/1/client/cros/crash_test.py
> File client/cros/crash_test.py (right):
> 
>
http://codereview.chromium.org/6577014/diff/1/client/cros/crash_test.py#newco...
> client/cros/crash_test.py:15: machine and generate a core dump. We want to
check
> that the correct crash
> Not necessarily the whole machine - both kernel or user process crashes are
> tested using this base class.
> 
>
http://codereview.chromium.org/6577014/diff/1/client/cros/crash_test.py#newco...
> client/cros/crash_test.py:289: **username: not used
> Feel free to remove this.
> 
>
http://codereview.chromium.org/6577014/diff/1/client/cros/crash_test.py#newco...
> client/cros/crash_test.py:497: - Reset rate limiting.
> I'd prefer not to list things at this level since they're apparent from the
code
> (but more importantly are likely to get out of date).

Have uploaded a revision - thanks for reading. Will push in the morning if no
issues.

Expand Messages | Collapse Messages