Make the clang plugin look for path components.

tools/clang/plugins/ChromeClassTester.cpp

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // A general interface for filtering and only acting on classes in Chromium C++
 // code.
 
 #include "ChromeClassTester.h"
 
+#include <sys/param.h>
+
 using namespace clang;
 
 namespace {
 
 bool starts_with(const std::string& one, const std::string& two) {
   return one.substr(0, two.size()) == two;
 }
 
 bool ends_with(const std::string& one, const std::string& two) {
   if (two.size() > one.size())
     return false;
 
   return one.substr(one.size() - two.size(), two.size()) == two;
 }
 
 }  // namespace
 
 ChromeClassTester::ChromeClassTester(CompilerInstance& instance)
     : instance_(instance),
       diagnostic_(instance.getDiagnostics()) {
   banned_namespaces_.push_back("std");
   banned_namespaces_.push_back("__gnu_cxx");
 
-  banned_directories_.push_back("third_party");
-  banned_directories_.push_back("native_client");
-  banned_directories_.push_back("breakpad");
-  banned_directories_.push_back("courgette");
-  banned_directories_.push_back("ppapi");
-  banned_directories_.push_back("/usr");
-  banned_directories_.push_back("testing");
-  banned_directories_.push_back("googleurl");
-  banned_directories_.push_back("v8");
-  banned_directories_.push_back("sdch");
+  // If the path to the file in question has this as a path component, than

[Nico, 2011/02/24 16:00:05]

then

+  // abort. We just do a simple string find on the path.
+  banned_directories_.push_back("third_party/");
+  banned_directories_.push_back("native_client/");
+  banned_directories_.push_back("breakpad/");
+  banned_directories_.push_back("courgette/");
+  banned_directories_.push_back("ppapi/");
+  banned_directories_.push_back("usr/");
+  banned_directories_.push_back("testing/");
+  banned_directories_.push_back("googleurl/");
+  banned_directories_.push_back("v8/");
+  banned_directories_.push_back("sdch/");
 
   // You are standing in a mazy of twisty dependencies, all resolved by
   // putting everything in the header.
-  banned_directories_.push_back("chrome/test/automation");
+  banned_directories_.push_back("automation/");
 
   // Used in really low level threading code that probably shouldn't be out of
   // lined.
   ignored_record_names_.push_back("ThreadLocalBoolean");
 
   // A complicated pickle derived struct that is all packed integers.
   ignored_record_names_.push_back("Header");
 
   // Part of the GPU system that uses multiple included header
   // weirdness. Never getting this right.
@@ skipping 120 matching lines @@
       // Don't complain about these things in implementation files.
       if (ends_with(b, ".cc") || ends_with(b, ".cpp") || ends_with(b, ".mm")) {
         return true;
       }
 
       // Don't complain about autogenerated protobuf files.
       if (ends_with(b, ".pb.h")) {
         return true;
       }
 
-      // Strip out all preceding path garbage. Linux and mac builds have
-      // different path garbage, but after doing this, the path should be
-      // relative to the root of the source tree. (If we didn't require
-      // relative paths, we could have just used realpath().)
-      if (!b.empty() && b[0] != '/') {
-        size_t i = 0;
-        for (; i < b.size() && (b[i] == '.' || b[i] == '/'); ++i) {}
-        b = b.substr(i);
+      // Resolve the path.
+      char resolvedPath[MAXPATHLEN];
+      if (realpath(b.c_str(), resolvedPath)) {

[Nico, 2011/02/24 16:00:05]

did you measure the build time impact of this?

[Elliot Glaysher, 2011/02/25 01:51:21]

On linux, this adds 14 seconds to make -j8 chrome (11m11 before, 11m25s after).

+        b = resolvedPath;
       }
 
       for (std::vector<std::string>::const_iterator it =
                banned_directories_.begin();
            it != banned_directories_.end(); ++it) {
-        if (starts_with(b, *it))
+        // If we can find any of the banned path components in this path, than

[Nico, 2011/02/24 16:00:05]

then

+        // this file is rejected.
+        if (b.find(*it) != std::string::npos)

[Nico, 2011/02/24 16:00:05]

hm, i'm almost certain this will start banning directories it's not supposed to
at some point. Can you try to guess the source root at plugin startup somehow?
(e.g. realpath() on the input file, then look for "src" from the left and check
if chrome/chrome.gyp and build/common.gypi exist relative from that path)

[Elliot Glaysher, 2011/02/25 01:51:21]

The relative paths will often be bellow the directories searched for; realpath()
will still be needed to resolve stuff.

           return true;
       }
     }
   }
 
   return false;
 }
 
 bool ChromeClassTester::IsIgnoredType(const std::string& base_name) {
   for (std::vector<std::string>::const_iterator it =
            ignored_record_names_.begin();
        it != ignored_record_names_.end(); ++it) {
     if (base_name == *it)
       return true;
   }
 
   return false;
 }