Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 6577003: Entire DOMBrowser stack (Closed)

Created:
9 years, 10 months ago by rharrison
Modified:
9 years, 6 months ago
CC:
chromium-reviews, arv (Not doing code reviews), davemoore+watch_chromium.org, rjkroege, oshima
Visibility:
Public.

Description

Entire DOMBrowser stack. This CL is the entire DOMBrowser stack in a single set so that reviewers can reference what I am doing in sub-CLs. This CL will not be committed, so review should occur on the sub-CLs. I will attempt to keep this up to date with the changes occuring in other reviews, but it might be out of date. Don't take it as canon if there is a sub-CL. Patch from Ryan Harrison <rharrison@chromium.org>; BUG=none TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1054 lines, -36 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/frame/browser_view.h View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/frame/browser_view.cc View 1 chunk +2 lines, -1 line 0 comments Download
A chrome/browser/chromeos/webui/login/browser/dom_browser.h View 1 chunk +33 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/webui/login/browser/dom_browser.cc View 1 chunk +60 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/webui/login/browser/dom_browser_view.h View 1 chunk +63 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/webui/login/browser/dom_browser_view.cc View 1 chunk +142 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/webui/login/browser/dom_browser_view_layout.h View 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/webui/login/browser/dom_browser_view_layout.cc View 1 chunk +167 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/webui/login/frame/dom_browser_frame.h View 1 chunk +34 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/webui/login/frame/dom_browser_frame.cc View 1 chunk +49 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/webui/login/frame/dom_browser_frame_view.h View 1 chunk +39 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/webui/login/frame/dom_browser_frame_view.cc View 1 chunk +81 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/webui/login/login_container_ui.h View 1 chunk +80 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/webui/login/login_container_ui.cc View 1 chunk +99 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/webui/login/login_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/webui/login/login_ui_helpers.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/webui/login/login_ui_helpers.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/webui/login/mock_login_ui_helpers.h View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/resources/login_container.html View 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.h View 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/ui/browser.cc View 3 chunks +13 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.h View 7 chunks +25 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view.cc View 6 chunks +20 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_view_layout.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/frame/opaque_browser_frame_view.h View 3 chunks +12 lines, -1 line 0 comments Download
M chrome/browser/webui/web_ui_factory.cc View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +12 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/common/url_constants.cc View 2 chunks +5 lines, -1 line 0 comments Download
M views/view.h View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Nikita (slow)
For a long term solution think about a way to combine OOBE / sign in ...
9 years, 9 months ago (2011-02-28 14:13:43 UTC) #1
Nikita (slow)
To simplify understanding of the whole design, please create a simple diagram / description how ...
9 years, 9 months ago (2011-02-28 14:16:25 UTC) #2
rharrison
On 2011/02/28 14:16:25, Nikita Kostylev wrote: > To simplify understanding of the whole design, please ...
9 years, 9 months ago (2011-02-28 19:09:37 UTC) #3
commit-bot: I haz the power
No LGTM from valid reviewers yet.
9 years, 9 months ago (2011-03-03 17:07:40 UTC) #4
rharrison
9 years, 9 months ago (2011-03-03 17:07:59 UTC) #5
On 2011/03/03 17:07:40, commit-bot wrote:
> No LGTM from valid reviewers yet.
My bad, clicked commit on the wrong CL

Powered by Google App Engine
This is Rietveld 408576698