Issue 6576058: Removing PS option from PdfPsMetafile

Issue 6576058: Removing PS option from PdfPsMetafile (Closed)

Created:
9 years, 10 months ago by dpapad

Modified:
9 years, 7 months ago

Reviewers:
vandebo (ex-Chrome)

CC:
chromium-reviews, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Removing PS option from PdsPsMetafile Also removing PS unit test. BUG=NONE TEST= tested on Linux Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76053

Patch Set 2 : Removed obsolete constructor calls from unit tests #

Total comments: 4

Patch Set 3 : Updated comments and copyright years #

Patch Set 4 : Updated more comments #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -124 lines)			Patch
M	chrome/renderer/print_web_view_helper_linux.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	printing/pdf_ps_metafile_cairo.h	View	1 2 3	4 chunks	+15 lines, -31 lines	0 comments	Download
M	printing/pdf_ps_metafile_cairo.cc	View	1 2	7 chunks	+9 lines, -42 lines	0 comments	Download
M	printing/pdf_ps_metafile_cairo_unittest.cc	View	1 2	5 chunks	+4 lines, -49 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

vandebo (ex-Chrome)

Lets see some try job results too. http://codereview.chromium.org/6576058/diff/2001/printing/pdf_ps_metafile_cairo.cc File printing/pdf_ps_metafile_cairo.cc (right): http://codereview.chromium.org/6576058/diff/2001/printing/pdf_ps_metafile_cairo.cc#newcode73 printing/pdf_ps_metafile_cairo.cc:73: : surface_(NULL), ...

9 years, 10 months ago (2011-02-25 00:10:35 UTC) #2

dpapad

http://codereview.chromium.org/6576058/diff/2001/printing/pdf_ps_metafile_cairo.cc File printing/pdf_ps_metafile_cairo.cc (right): http://codereview.chromium.org/6576058/diff/2001/printing/pdf_ps_metafile_cairo.cc#newcode73 printing/pdf_ps_metafile_cairo.cc:73: : surface_(NULL), context_(NULL) { On 2011/02/25 00:10:35, vandebo wrote: ...

9 years, 10 months ago (2011-02-25 02:26:34 UTC) #3

LGTM

Expand Messages | Collapse Messages