Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 6576056: Create power_ARMSettings test (Closed)

Created:
9 years, 10 months ago by Simon Que
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org, truty+cc_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli
Visibility:
Public.

Description

Create power_ARMSettings test Create power_ARMSettings autotest based on power_x86Settings autotest. Currently only checks wifi and usb settings. BUG=chromium-os:12455 TEST=Run power_ARMSettings test on ARM, should pass. Change-Id: I750a47f3594e665efeb8576f0dc2ccab592a16f7 Signed-off-by: Simon Que <sque@chromium.org>; Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=0ee81ce

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -0 lines) Patch
A client/site_tests/power_ARMSettings/control View 1 1 chunk +23 lines, -0 lines 0 comments Download
A client/site_tests/power_ARMSettings/power_ARMSettings.py View 1 1 chunk +91 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Simon Que
9 years, 10 months ago (2011-02-24 23:23:23 UTC) #1
Sameer Nanda
LGTM w/ one nit about comment. http://codereview.chromium.org/6576056/diff/1/client/site_tests/power_ARMSettings/control File client/site_tests/power_ARMSettings/control (right): http://codereview.chromium.org/6576056/diff/1/client/site_tests/power_ARMSettings/control#newcode20 client/site_tests/power_ARMSettings/control:20: from power standpoint. ...
9 years, 10 months ago (2011-02-25 00:30:08 UTC) #2
Sameer Nanda
Oh, and can you change year to 2011 from 2010 in both the files. On ...
9 years, 10 months ago (2011-02-25 00:30:44 UTC) #3
Simon Que
9 years, 10 months ago (2011-02-25 00:49:58 UTC) #4
http://codereview.chromium.org/6576056/diff/1/client/site_tests/power_ARMSett...
File client/site_tests/power_ARMSettings/control (right):

http://codereview.chromium.org/6576056/diff/1/client/site_tests/power_ARMSett...
client/site_tests/power_ARMSettings/control:20: from power standpoint.
On 2011/02/25 00:30:09, Sameer Nanda wrote:
> Lets remove MCH, PCIe and CPU MSRs from the description since they may not
apply
> to ARM.

Done.

Powered by Google App Engine
This is Rietveld 408576698