Issue 6576051: run_remote_tests: fix bug where new symlink got created instead of update

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6576051: run_remote_tests: fix bug where new symlink got created instead of update (Closed)

Created:
9 years, 10 months ago by Mandeep Singh Baines

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

run_remote_tests: fix bug where new symlink got created instead of update The one symlink should be update instead of new links being created. BUG=12233 TEST=Ran run_remote_test.sh many time and verified that the link is updated. Change-Id: I63f325e03439e5c922e9fe2300444193146182f9 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=7b86ec0

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	run_remote_tests.sh	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sosa

9 years, 10 months ago (2011-02-25 14:39:54 UTC) #2

LGTM

On Thu, Feb 24, 2011 at 9:06 PM,  <msb@chromium.org> wrote:
> Reviewers: sosa,
>
> Description:
> run_remote_tests: fix bug where new symlink got created instead of update
>
> The one symlink should be update instead of new links being created.
>
> BUG=12233
> TEST=Ran run_remote_test.sh many time and verified that the link is updated.
>
> Change-Id: I63f325e03439e5c922e9fe2300444193146182f9
>
> Please review this at http://codereview.chromium.org/6576051/
>
> SVN Base: http://git.chromium.org/git/crosutils.git@master
>
> Affected files:
>  M run_remote_tests.sh
>
>
> Index: run_remote_tests.sh
> diff --git a/run_remote_tests.sh b/run_remote_tests.sh
> index
>
2c6dfd0a1ecbefc95354cf7780e8350b787889a5..b27be5baec5cce199800c839812e4bea13a3d16b
> 100755
> --- a/run_remote_tests.sh
> +++ b/run_remote_tests.sh
> @@ -79,7 +79,7 @@ function cleanup() {
>      [[ ${RAN_ANY_TESTS} -eq ${FLAGS_FALSE} ]]; then
>     rm -rf "${TMP}"
>   else
> -    ln -sf "${TMP}" /tmp/run_remote_tests.latest
> +    ln -nsf "${TMP}" /tmp/run_remote_tests.latest
>     echo ">>> Details stored under ${TMP}"
>   fi
>   stop_ssh_agent
>
>
>

Expand Messages | Collapse Messages