Issue 6576048: libmetrics -- release the shared file lock when closing, handle EINTR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6576048: libmetrics -- release the shared file lock when closing, handle EINTR. (Closed)

Created:
9 years, 10 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
Daniel Erat

CC:
chromium-os-reviews_chromium.org, petkov, Luigi Semenzato, sosa

Base URL:
ssh://git@gitrw.chromium.org:9222/metrics.git@master

Visibility:
Public.

Description

libmetrics -- release the shared file lock when closing, handle EINTR. BUG=chromium-os:11125 TEST=unit tests, tested on device Change-Id: I126af62f77e4fd0f098d441038f8dc94c0020ac2 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=e3c2ae0

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -12 lines)			Patch
	M	metrics_library.cc	View		3 chunks	+10 lines, -12 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

petkov

I've been unable to reproduce the problem but this change may make it go away ...

9 years, 10 months ago (2011-02-24 20:26:00 UTC) #1

Daniel Erat

On 2011/02/24 20:26:00, petkov wrote: > I've been unable to reproduce the problem but this ...

9 years, 10 months ago (2011-02-24 20:33:20 UTC) #2

Daniel Erat

9 years, 10 months ago (2011-02-24 20:33:30 UTC) #3

On 2011/02/24 20:33:20, Daniel Erat wrote:
> On 2011/02/24 20:26:00, petkov wrote:
> > I've been unable to reproduce the problem but this change may make it go
away
> > ;-)
> 
> Yeah, that looks like it could explain it.  Thanks!

LGTM!

Expand Messages | Collapse Messages