Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 6576041: Add support for flash device parameters printing to bct_dump. (Closed)

Created:
9 years, 10 months ago by robotboy
Modified:
9 years, 7 months ago
Reviewers:
pchen, vb, sjg
CC:
chromium-os-reviews_chromium.org
Visibility:
Public.

Description

Add support for flash device parameters printing to bct_dump. This adds human readable output for SPI and SDMMC device parameters stored in a BCT file. This includes clock divisors, boot flash type and various flash type specific parameters. BUG=None TEST=bct_dump /build/tegra2_seaboard/u-boot/image.bin Change-Id: I9f233abf53627ddb00159e105cfa3ff01d38ce5c This CL depends on: http://codereview.chromium.org/6579041/ Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=496f965

Patch Set 1 #

Patch Set 2 : Fix for correct tab stops (8 instead of 4) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -18 lines) Patch
M bct_dump.c View 1 4 chunks +110 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
robotboy
9 years, 10 months ago (2011-02-24 18:33:31 UTC) #1
robotboy
I have updated this CL to work with 8-space tab stops instead of 4. It ...
9 years, 9 months ago (2011-02-28 19:02:48 UTC) #2
sjg
On 2011/02/28 19:02:48, robotboy wrote: > I have updated this CL to work with 8-space ...
9 years, 9 months ago (2011-03-01 00:34:59 UTC) #3
robotboy
Do you have a preference for a different alignment character? Would you prefer spaces? Thanks, ...
9 years, 9 months ago (2011-03-01 00:42:17 UTC) #4
sjg
No, don't worry. I meant the fact that the alignment is done with dots in ...
9 years, 9 months ago (2011-03-01 00:47:21 UTC) #5
sjg
9 years, 9 months ago (2011-03-01 05:08:53 UTC) #6
On 2011/03/01 00:47:21, sjg wrote:
> No, don't worry. I meant the fact that the alignment is done with dots
> in the string instead of %-15s for example - Simon
> 
> On Mon, Feb 28, 2011 at 4:42 PM, Anton Staaf <mailto:robotboy@chromium.org>
wrote:
> > Do you have a preference for a different alignment character? &nbsp;Would
you
> > prefer spaces?
> > Thanks,
> > &nbsp;&nbsp; &nbsp;Anton
> >
> > On Mon, Feb 28, 2011 at 4:34 PM, <mailto:sjg@chromium.org> wrote:
> >>
> >> On 2011/02/28 19:02:48, robotboy wrote:
> >>>
> >>> I have updated this CL to work with 8-space tab stops instead of 4.
&nbsp;It
> >>> now
> >>> depends on the CL that fixes the rest of my changes. &nbsp;PTAL.
> >>
> >>> Thanks,
> >>> &nbsp; &nbsp; Anton
> >>
> >> LGTM
> >>
> >> (I'm not too keen on the .... in the strings though!)
> >>
> >>
> >> http://codereview.chromium.org/6576041/
> >
> >

But that was a previous CL, so LGTM as I said.

Powered by Google App Engine
This is Rietveld 408576698