Issue 6576032: Check for excessive dimensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6576032: Check for excessive dimensions. (Closed)

Created:
9 years, 10 months ago by Chris Evans

Modified:
9 years, 6 months ago

Reviewers:
jschuh, cevans

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Check for excessive dimensions. BUG=72173 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76028

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jschuh

SGTM. One dumb question though. Are zero dimensions allowed? If not, you could simplify to ...

9 years, 10 months ago (2011-02-25 02:06:40 UTC) #2

cevans

9 years, 10 months ago (2011-02-25 02:34:02 UTC) #3

On Thu, Feb 24, 2011 at 6:06 PM, <jschuh@chromium.org> wrote:

> SGTM. One dumb question though. Are zero dimensions allowed?


I do not know; and I'm playing it conservatively after our previous
experiments here, for now :)


> If not, you could
> simplify to the following (just for readability):
>
> if (w <= 0 || h <= 0 || h >= (INT_MAX / 4) / w)
>
>
>
> http://codereview.chromium.org/6576032/
>

Expand Messages | Collapse Messages