src/objects-inl.h - Issue 6576024: (early draft) Strict mode - throw exception on assignment to read only property.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-inl.h

Issue 6576024: (early draft) Strict mode - throw exception on assignment to read only property. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Assign to read only property in strict mode. Created 9 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-inl.h

diff --git a/src/objects-inl.h b/src/objects-inl.h

index f955d334d20b7403826a3c877d091ea01d9ab955..dedb19956834a17b933e167d76ab3ae470e5e77d 100644

--- a/src/objects-inl.h

+++ b/src/objects-inl.h

@@ -2619,7 +2619,8 @@ Code::Flags Code::ComputeFlags(Kind kind,

ASSERT(extra_ic_state == kNoExtraICState ||

(kind == CALL_IC && (ic_state == MONOMORPHIC ||

ic_state == MONOMORPHIC_PROTOTYPE_FAILURE)) ||

- (kind == STORE_IC));

+ (kind == STORE_IC) ||

+ (kind == KEYED_STORE_IC));

// Compute the bit mask.

int bits = kind << kFlagsKindShift;

if (in_loop) bits |= kFlagsICInLoopMask;

@@ -3741,7 +3742,8 @@ MaybeObject* JSObject::SetHiddenPropertiesObject(Object* hidden_obj) {

ASSERT(!IsJSGlobalProxy());

return SetPropertyPostInterceptor(Heap::hidden_symbol(),

hidden_obj,

- DONT_ENUM);

+ DONT_ENUM,

+ kNonStrictMode);

}

« no previous file with comments | « src/objects.cc ('k') | src/parser.cc » ('j') | no next file with comments »