Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/ic-inl.h

Issue 6576024: (early draft) Strict mode - throw exception on assignment to read only property. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Assign to read only property in strict mode. Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ic.cc ('k') | src/messages.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2008 the V8 project authors. All rights reserved. 1 // Copyright 2006-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 // Convert target address to the code object. Code::GetCodeFromTargetAddress 69 // Convert target address to the code object. Code::GetCodeFromTargetAddress
70 // is safe for use during GC where the map might be marked. 70 // is safe for use during GC where the map might be marked.
71 Code* result = Code::GetCodeFromTargetAddress(target); 71 Code* result = Code::GetCodeFromTargetAddress(target);
72 ASSERT(result->is_inline_cache_stub()); 72 ASSERT(result->is_inline_cache_stub());
73 return result; 73 return result;
74 } 74 }
75 75
76 76
77 void IC::SetTargetAtAddress(Address address, Code* target) { 77 void IC::SetTargetAtAddress(Address address, Code* target) {
78 ASSERT(target->is_inline_cache_stub() || target->is_compare_ic_stub()); 78 ASSERT(target->is_inline_cache_stub() || target->is_compare_ic_stub());
79 #ifdef DEBUG
80 // STORE_IC and KEYED_STORE_IC use Code::extra_ic_state() to mark
81 // ICs as strict mode. The strict-ness of the IC must be preserved.
82 Code* old_target = GetTargetAtAddress(address);
83 if (old_target->kind() == Code::STORE_IC ||
84 old_target->kind() == Code::KEYED_STORE_IC) {
85 ASSERT(old_target->extra_ic_state() == target->extra_ic_state());
86 }
87 #endif
79 Assembler::set_target_address_at(address, target->instruction_start()); 88 Assembler::set_target_address_at(address, target->instruction_start());
80 } 89 }
81 90
82 91
83 InlineCacheHolderFlag IC::GetCodeCacheForObject(Object* object, 92 InlineCacheHolderFlag IC::GetCodeCacheForObject(Object* object,
84 JSObject* holder) { 93 JSObject* holder) {
85 if (object->IsJSObject()) { 94 if (object->IsJSObject()) {
86 return GetCodeCacheForObject(JSObject::cast(object), holder); 95 return GetCodeCacheForObject(JSObject::cast(object), holder);
87 } 96 }
88 // If the object is a value, we use the prototype map for the cache. 97 // If the object is a value, we use the prototype map for the cache.
(...skipping 22 matching lines...) Expand all
111 JSObject* IC::GetCodeCacheHolder(Object* object, InlineCacheHolderFlag holder) { 120 JSObject* IC::GetCodeCacheHolder(Object* object, InlineCacheHolderFlag holder) {
112 Object* map_owner = (holder == OWN_MAP ? object : object->GetPrototype()); 121 Object* map_owner = (holder == OWN_MAP ? object : object->GetPrototype());
113 ASSERT(map_owner->IsJSObject()); 122 ASSERT(map_owner->IsJSObject());
114 return JSObject::cast(map_owner); 123 return JSObject::cast(map_owner);
115 } 124 }
116 125
117 126
118 } } // namespace v8::internal 127 } } // namespace v8::internal
119 128
120 #endif // V8_IC_INL_H_ 129 #endif // V8_IC_INL_H_
OLDNEW
« no previous file with comments | « src/ic.cc ('k') | src/messages.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698