(early draft) Strict mode - throw exception on assignment to read only property.

src/stub-cache.h

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 163 matching lines @@
       Map* transition = NULL);
 
   MUST_USE_RESULT static MaybeObject* ComputeKeyedStoreSpecialized(
       JSObject* receiver);
 
   MUST_USE_RESULT static MaybeObject* ComputeKeyedStorePixelArray(
       JSObject* receiver);
 
   MUST_USE_RESULT static MaybeObject* ComputeKeyedLoadOrStoreExternalArray(
       JSObject* receiver,
-      bool is_store);
+      bool is_store,
+      Code::ExtraICState extra_ic_state);

[Martin Maly, 2011/02/24 06:33:34]

I am leaning toward changing all of these to StrictModeFlag so the purpose is
clearer. Passing ExtraICState seems too cryptic.

[Lasse Reichstein, 2011/02/24 12:37:54]

Agree. If the extra IC state is just the one bit, just use the original bit for
it.

 
   // ---
 
   MUST_USE_RESULT static MaybeObject* ComputeCallField(int argc,
                                                        InLoopFlag in_loop,
                                                        Code::Kind,
                                                        String* name,
                                                        Object* object,
                                                        JSObject* holder,
                                                        int index);
@@ skipping 636 matching lines @@
   MUST_USE_RESULT MaybeObject* CompileKeyedStoreStub(
       ExternalArrayType array_type, Code::Flags flags);
 
  private:
   MaybeObject* GetCode(Code::Flags flags);
 };
 
 } }  // namespace v8::internal
 
 #endif  // V8_STUB_CACHE_H_