RunCommand was catching and rethrowing an exception, which seemed to generate

RunCommand was catching and rethrowing an exception, which seemed to generate
extra noise in the final exception output.

This change stops catching and rethrowing the same exception, and generally
makes the RunCommand slightly more readable (if longer).

Some unit tests are added, but they only test RunCommand, and not all options
to RunCommand.

BUG=chromium-os:11717
TEST=Manual, and new lib/cros_build_lib_unittest

Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=01c8423

[sosa, 2011-02-24 00:23:36]

Thanks for adding a unittest!

http://codereview.chromium.org/6576016/diff/1/lib/cros_build_lib.py
File lib/cros_build_lib.py (right):

http://codereview.chromium.org/6576016/diff/1/lib/cros_build_lib.py#newcode76
lib/cros_build_lib.py:76: Info('PROGRAM(%s) -> RunCommand: retrying %r in dir
%s' %
Too much indention

http://codereview.chromium.org/6576016/diff/1/lib/cros_build_lib_unittest.py
File lib/cros_build_lib_unittest.py (right):

http://codereview.chromium.org/6576016/diff/1/lib/cros_build_lib_unittest.py#...
lib/cros_build_lib_unittest.py:7: """Unit tests for ctest."""
docstring

http://codereview.chromium.org/6576016/diff/1/lib/cros_build_lib_unittest.py#...
lib/cros_build_lib_unittest.py:17: #RunCommand(cmd, print_cmd=True,
error_ok=False, error_message=None,
left for reference?

http://codereview.chromium.org/6576016/diff/1/lib/cros_build_lib_unittest.py#...
lib/cros_build_lib_unittest.py:21: def setUp(self):
Remove

http://codereview.chromium.org/6576016/diff/1/lib/cros_build_lib_unittest.py#...
lib/cros_build_lib_unittest.py:55: self.assertTrue(result != 0)
Should prob add a test with error_ok=False and use AssertRaises

[dgarrett, 2011-02-24 01:06:46]

http://codereview.chromium.org/6576016/diff/1/lib/cros_build_lib_unittest.py
File lib/cros_build_lib_unittest.py (right):

http://codereview.chromium.org/6576016/diff/1/lib/cros_build_lib_unittest.py#...
lib/cros_build_lib_unittest.py:7: """Unit tests for ctest."""
On 2011/02/24 00:23:36, sosa wrote:
> docstring

Done.

http://codereview.chromium.org/6576016/diff/1/lib/cros_build_lib_unittest.py#...
lib/cros_build_lib_unittest.py:17: #RunCommand(cmd, print_cmd=True,
error_ok=False, error_message=None,
On 2011/02/24 00:23:36, sosa wrote:
> left for reference?

Yeah, I meant to pull it out though.

Done.

http://codereview.chromium.org/6576016/diff/1/lib/cros_build_lib_unittest.py#...
lib/cros_build_lib_unittest.py:21: def setUp(self):
On 2011/02/24 00:23:36, sosa wrote:
> Remove

Done.

http://codereview.chromium.org/6576016/diff/1/lib/cros_build_lib_unittest.py#...
lib/cros_build_lib_unittest.py:55: self.assertTrue(result != 0)
On 2011/02/24 00:23:36, sosa wrote:
> Should prob add a test with error_ok=False and use AssertRaises

Yep. Meant to look up the name of that assert test method, but felt lazy when I
was otherwise done.

[sosa, 2011-02-24 01:30:32]

LGTM but before you commit, can you add short docstrings for each test method. 
These are very useful because when a unit test fails, the unittest harness
prints out the docstring of the failing test.