Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6575054: WebUI: Move the core files of WebUI from chrome/browser/webui to content/webui. (Closed)

Created:
9 years, 10 months ago by tfarina
Modified:
9 years, 7 months ago
Reviewers:
Avi (use Gerrit), jam
CC:
chromium-reviews, ajwong+watch_chromium.org, Ilya Sherman, dhollowa, ncarter (slow), nkostylev+cc_chromium.org, idana, Erik does not do reviews, dmaclach+watch_chromium.org, brettw-cc_chromium.org, tim (not reviewing), wez+watch_chromium.org, Raghu Simha, simonmorris+watch_chromium.org, pam+watch_chromium.org, sergeyu+watch_chromium.org, James Hawkins, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

WebUI: Move the core files of WebUI from chrome/browser/webui to content/browser/webui. BUG=59946 TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76020

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -106 lines) Patch
M chrome/browser/browser_signin.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/browser_url_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/web_page_view.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/notifications/system_notification.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/webui/accounts_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/webui/imageburner_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/webui/internet_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/webui/login/login_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/webui/menu_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/webui/menu_ui.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/webui/mobile_setup_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/webui/register_page_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/webui/system_info_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_host.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_web_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extensions_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/favicon_service.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_flow.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_setup_message_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_dialog_cloud.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_dialog_cloud_internal.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/remoting/remoting_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/remoting/setup_flow.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/remoting/setup_flow_login_step.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/sync_setup_flow.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_host_delegate_helper.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/html_dialog_window_controller_unittest.mm View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/app_launcher_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/bookmarks_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/conflicts_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/constrained_html_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/constrained_html_ui.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/crashes_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/devtools_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/downloads_dom_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/downloads_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/file_browse_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/flags_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/foreign_session_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/generic_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/gpu_internals_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/history2_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/history_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/html_dialog_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/html_dialog_ui.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/keyboard_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/mediaplayer_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/most_visited_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/net_internals_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/new_tab_page_sync_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/new_tab_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/ntp_login_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/ntp_login_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/options/autofill_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/options/options_managed_banner_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/options/options_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/options/personal_options_handler.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/plugins_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/print_preview_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/print_preview_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/remoting_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/settings_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/shown_sections_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/slideshow_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/webui/sync_internals_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/textfields_ui.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/webui/tips_handler.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/browsing_instance.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/site_instance.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/browser/tab_contents/render_view_host_manager.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/tab_contents/tab_contents.h View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
M content/browser/tab_contents/tab_contents.cc View 1 2 3 2 chunks +1 line, -1 line 0 comments Download
A + content/browser/webui/web_ui.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/webui/web_ui.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/webui/web_ui_browsertest.h View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/webui/web_ui_browsertest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/webui/web_ui_factory.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/webui/web_ui_factory.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/webui/web_ui_handler_browsertest.h View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
A + content/browser/webui/web_ui_handler_browsertest.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
A + content/browser/webui/web_ui_unittest.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/webui/web_ui_util.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + content/browser/webui/web_ui_util.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/content_browser.gypi View 1 2 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tfarina
Please, take a look.
9 years, 10 months ago (2011-02-25 01:15:07 UTC) #1
jam
lgtm with a green trybot run
9 years, 10 months ago (2011-02-25 01:39:38 UTC) #2
Avi (use Gerrit)
9 years, 10 months ago (2011-02-25 02:18:40 UTC) #3 
Looked it over, LGTM

Powered by Google App Engine
This is Rietveld 408576698