Issue 6575022: Revert "RunCommand was catching and rethrowing an exception, which seemed to generate"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6575022: Revert "RunCommand was catching and rethrowing an exception, which seemed to generate" (Closed)

Created:
9 years, 10 months ago by Luigi Semenzato

Modified:
9 years, 7 months ago

Reviewers:
davidjames, dgarrett

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git@master

Visibility:
Public.

Description

Revert "RunCommand was catching and rethrowing an exception, which seemed to generate" This reverts commit 01c84235827527cd2f938897a4a8dfcdbf877281. BUG=chromium-os:11717 TEST=none Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=3635aaa

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -102 lines)			Patch
	M	lib/cros_build_lib.py	View		1 chunk	+19 lines, -26 lines	0 comments	Download
	D	lib/cros_build_lib_unittest.py	View		1 chunk	+0 lines, -76 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Luigi Semenzato

This broke the build. http://build.chromium.org/p/chromiumos/builders/x86%20pineview%20binary/builds/3323/steps/cbuildbot/logs/stdio

9 years, 10 months ago (2011-02-24 03:12:52 UTC) #1

davidjames

9 years, 10 months ago (2011-02-24 03:14:26 UTC) #2

LGTM

Root cause of bug is that the new code sometimes throws exceptions when
exit_code=True, when it's just supposed to return the error code. Shouldn't be
hard to fix, but let's save that for regular working hours.

Expand Messages | Collapse Messages