Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 6575012: More autofill overlay HTML cleanup (Closed)

Created:
9 years, 10 months ago by Ilya Sherman
Modified:
9 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

More autofill overlay HTML cleanup * Use dashed-form ids for the credit cards overlay * Consolidate overlay css files. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=76125

Patch Set 1 #

Total comments: 2

Patch Set 2 : No <br>'s #

Patch Set 3 : Remove unused files #

Total comments: 2

Patch Set 4 : Use <div> in place of <span> #

Total comments: 2

Patch Set 5 : Don't change <div>s for now... #

Total comments: 1

Patch Set 6 : One selector per line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -55 lines) Patch
M chrome/browser/resources/options/autofill_edit_address_overlay.html View 1 2 3 4 5 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/autofill_edit_creditcard_overlay.css View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/autofill_edit_creditcard_overlay.html View 1 2 3 4 1 chunk +17 lines, -19 lines 0 comments Download
M chrome/browser/resources/options/autofill_edit_creditcard_overlay.js View 12 chunks +23 lines, -23 lines 0 comments Download
A + chrome/browser/resources/options/autofill_overlay.css View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/resources/options/options.html View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ilya Sherman
9 years, 10 months ago (2011-02-23 23:48:18 UTC) #1
arv (Not doing code reviews)
http://codereview.chromium.org/6575012/diff/1/chrome/browser/resources/options/autofill_edit_address_overlay.html File chrome/browser/resources/options/autofill_edit_address_overlay.html (right): http://codereview.chromium.org/6575012/diff/1/chrome/browser/resources/options/autofill_edit_address_overlay.html#newcode6 chrome/browser/resources/options/autofill_edit_address_overlay.html:6: <span i18n-content="fullNameLabel"></span><br> No, don't use br's. They are impossible ...
9 years, 10 months ago (2011-02-24 01:00:22 UTC) #2
Ilya Sherman
http://codereview.chromium.org/6575012/diff/1/chrome/browser/resources/options/autofill_edit_address_overlay.html File chrome/browser/resources/options/autofill_edit_address_overlay.html (right): http://codereview.chromium.org/6575012/diff/1/chrome/browser/resources/options/autofill_edit_address_overlay.html#newcode6 chrome/browser/resources/options/autofill_edit_address_overlay.html:6: <span i18n-content="fullNameLabel"></span><br> On 2011/02/24 01:00:22, arv wrote: > No, ...
9 years, 10 months ago (2011-02-24 04:08:02 UTC) #3
James Hawkins
http://codereview.chromium.org/6575012/diff/5001/chrome/browser/resources/options/autofill_overlay.css File chrome/browser/resources/options/autofill_overlay.css (right): http://codereview.chromium.org/6575012/diff/5001/chrome/browser/resources/options/autofill_overlay.css#newcode27 chrome/browser/resources/options/autofill_overlay.css:27: div.input label span { If you want display: block, ...
9 years, 10 months ago (2011-02-24 08:56:29 UTC) #4
Ilya Sherman
http://codereview.chromium.org/6575012/diff/5001/chrome/browser/resources/options/autofill_overlay.css File chrome/browser/resources/options/autofill_overlay.css (right): http://codereview.chromium.org/6575012/diff/5001/chrome/browser/resources/options/autofill_overlay.css#newcode27 chrome/browser/resources/options/autofill_overlay.css:27: div.input label span { On 2011/02/24 08:56:30, James Hawkins ...
9 years, 10 months ago (2011-02-24 10:04:00 UTC) #5
arv (Not doing code reviews)
I would prefer if you only do the class/id renames in this patch. See Stuart's ...
9 years, 10 months ago (2011-02-24 23:45:54 UTC) #6
Ilya Sherman
http://codereview.chromium.org/6575012/diff/6001/chrome/browser/resources/options/autofill_edit_address_overlay.html File chrome/browser/resources/options/autofill_edit_address_overlay.html (right): http://codereview.chromium.org/6575012/diff/6001/chrome/browser/resources/options/autofill_edit_address_overlay.html#newcode32 chrome/browser/resources/options/autofill_edit_address_overlay.html:32: <div i18n-content="cityLabel"></div> On 2011/02/24 23:45:54, arv wrote: > This ...
9 years, 10 months ago (2011-02-25 07:29:01 UTC) #7
arv (Not doing code reviews)
LGTM http://codereview.chromium.org/6575012/diff/7001/chrome/browser/resources/options/autofill_overlay.css File chrome/browser/resources/options/autofill_overlay.css (right): http://codereview.chromium.org/6575012/diff/7001/chrome/browser/resources/options/autofill_overlay.css#newcode1 chrome/browser/resources/options/autofill_overlay.css:1: #autofill-edit-address-overlay, #autofill-edit-credit-card-overlay { one selector per line
9 years, 10 months ago (2011-02-25 17:46:32 UTC) #8
Ilya Sherman
9 years, 10 months ago (2011-02-26 00:18:11 UTC) #9 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698