Fixed the memory leak of callback Task in PostPingMessage....

chrome/browser/metrics/thread_watcher.cc

Index: chrome/browser/metrics/thread_watcher.cc
===================================================================
--- chrome/browser/metrics/thread_watcher.cc	(revision 75760)
+++ chrome/browser/metrics/thread_watcher.cc	(working copy)
@@ -102,18 +102,22 @@
   // Send a ping message to the watched thread.
   Task* callback_task = method_factory_.NewRunnableMethod(
       &ThreadWatcher::OnPongMessage, ping_sequence_number_);
-  BrowserThread::PostTask(
-      thread_id(),
-      FROM_HERE,
-      NewRunnableFunction(
-          &ThreadWatcher::OnPingMessage, thread_id_, callback_task));
-
-  // Post a task to check the responsiveness of watched thread.
-  MessageLoop::current()->PostDelayedTask(
-      FROM_HERE,
-      method_factory_.NewRunnableMethod(
-          &ThreadWatcher::OnCheckResponsiveness, ping_sequence_number_),
-      unresponsive_time_.InMilliseconds());
+  if (BrowserThread::PostTask(
+          thread_id(),
+          FROM_HERE,
+          NewRunnableFunction(
+              &ThreadWatcher::OnPingMessage, thread_id_, callback_task))) {
+      // Post a task to check the responsiveness of watched thread.
+      MessageLoop::current()->PostDelayedTask(
+          FROM_HERE,
+          method_factory_.NewRunnableMethod(
+              &ThreadWatcher::OnCheckResponsiveness, ping_sequence_number_),
+          unresponsive_time_.InMilliseconds());
+  } else {
+    // Watched thread might have gone away, stop watching it.
+    delete callback_task;
+    DeActivateThreadWatching();

[willchan no longer on Chromium, 2011/02/23 23:39:02]

I have not re-read the changelist since the last round of big changes, so you
should get Jim to look at this. In particular, I'm don't know if
DeActivateThreadWatching() is correct here. It probably is, I just don't know
since I forgot how the CL works :)

+  }
 }
 
 void ThreadWatcher::OnPongMessage(uint64 ping_sequence_number) {