Issue 6574009: If a public key is present, disallow old style full payloads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6574009: If a public key is present, disallow old style full payloads. (Closed)

Created:
9 years, 10 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git@master

Visibility:
Public.

Description

If a public key is present, disallow old style full payloads. This is necessary to ensure that if a public key is present the payload is signed and the signature passes verification. BUG=chromium-os:11760 TEST=unit tests, tested on device Change-Id: I6af61ead0e918c0b971dbcfeabcab3be03e6eb97 Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=abc7bc0

Patch Set 1 #

Created: 9 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -16 lines)			Patch
M	action_processor.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	delta_performer.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	delta_performer.cc	View	1 chunk	+3 lines, -2 lines	0 comments	Download
M	omaha_response_handler_action.h	View	3 chunks	+5 lines, -3 lines	0 comments	Download
M	omaha_response_handler_action.cc	View	2 chunks	+10 lines, -0 lines	0 comments	Download
M	omaha_response_handler_action_unittest.cc	View	8 chunks	+21 lines, -5 lines	0 comments	Download
M	update_attempter.cc	View	1 chunk	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

LGTM btw, do you think it's time we ripped out old style image support from ...

9 years, 10 months ago (2011-02-23 22:26:30 UTC) #2

petkov

9 years, 10 months ago (2011-02-23 22:30:12 UTC) #3

On 2011/02/23 22:26:30, adlr wrote:
> LGTM
> 
> btw, do you think it's time we ripped out old style image support from the
> updater? Seems like it's dead weight at this point.

I believe that's the right thing to do, however, the network test lab is still
using old style updates.

Expand Messages | Collapse Messages